Add AttributeDict container for Fabric #18943
Conversation
awaelchli
added
feature
github-actions
bot
added
fabric
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
awaelchli
added
the
fun
awaelchli
requested review from
carmocca,
justusschock,
Borda,
williamFalcon,
edenlightning and
lantiga
as code owners
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflowThese checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 pytorch_lightning: Benchmarks
These checks are required after the changes to 🟢 fabric: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 lightning_fabric: CPU workflowThese checks are required after the changes to 🟢 lightning_fabric: Azure GPU
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 installThese checks are required after the changes to Thank you for your contribution! 💜
|
There was a problem hiding this comment.
I think this pattern is not very Pythonic and can be confusing for users who are not super knowledgeable about Python: there's already been discussions around whether it's a good idea or not: https://lwn.net/Articles/818777
However, if we still want to suggest it, I would not call it State which might sound like this is the state of Fabric, or the model, or something similar to new users.
I would be specific and call it AttributeDict as before, which is exactly what it is and has been around for at leat 13 years (https://code.activestate.com/recipes/576972-attrdict)
awaelchli
changed the title
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18943 +/- ##
=========================================
- Coverage 76% 54% -22%
=========================================
Files 443 438 -5
Lines 36120 36030 -90
=========================================
- Hits 27303 19430 -7873
- Misses 8817 16600 +7783 |
What does this PR do?
Fixes #18515
Adds a convenience container to make training scripts stateful. An immediate application of this would be a script like the one in lit-gpt, where state gets defined here and accessed in several places.
📚 Documentation preview 📚: https://pytorch-lightning--18943.org.readthedocs.build/en/18943/
cc @Borda @justusschock @awaelchli @carmocca