Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a link for the best checkpoint #19304

Open
shenmishajing opened this issue Jan 17, 2024 · 0 comments
Open

Create a link for the best checkpoint #19304

shenmishajing opened this issue Jan 17, 2024 · 0 comments
Labels
callback: model checkpoint feature Is an improvement or enhancement

Comments

@shenmishajing
Copy link
Contributor

shenmishajing commented Jan 17, 2024

Description & Motivation

As illustrated in #19294 , since we already implement the link of last.ckpt, how about adding a new feature on best.ckpt? Although we support saving the topk checkpoints already, there is no consistent way to reference the top1 checkpoint.

Screenshot 2024-01-16 at 18 30 55

For example, in the above figure, I have to check the files under the folder work_dirs/medclip_resnet50_iu_xray_R2GenGPT_30x/2024.01.16_17.44.40.927262/checkpoints to determine the file name epoch:5-val_loss:3.264.ckpt to reference the best checkpoint if I have not created the best.ckpt checkpoint. It will be more convenient if we implement the hard link of best.ckpt also. It can be implemented with the similar code as the last.ckpt part.

Pitch

Create a link for the best checkpoint when it is updated.

Alternatives

No response

Additional context

No response

cc @Borda @carmocca @awaelchli

@shenmishajing shenmishajing added feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers labels Jan 17, 2024
@awaelchli awaelchli changed the title [Feature Request] Also create a link for the best checkpoint Create a link for the best checkpoint Jan 20, 2024
@awaelchli awaelchli added callback: model checkpoint and removed needs triage Waiting to be triaged by maintainers labels Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback: model checkpoint feature Is an improvement or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants