Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Train in run_pretrain_routine? #2431

Closed
ruotianluo opened this issue Jun 30, 2020 · 2 comments
Closed

Train in run_pretrain_routine? #2431

ruotianluo opened this issue Jun 30, 2020 · 2 comments
Labels
feature Is an improvement or enhancement help wanted Open to be worked on

Comments

@ruotianluo
Copy link
Contributor

I see the train() is run in run_pretrain_routine, doesn't it look wierd? At least violating the function name.

https://github.com/PyTorchLightning/pytorch-lightning/blob/d4a02e3bd8471946c606fef7512ce44d42f07d3a/pytorch_lightning/trainer/trainer.py#L1003
@ruotianluo ruotianluo added feature Is an improvement or enhancement help wanted Open to be worked on labels Jun 30, 2020
@awaelchli
Copy link
Contributor

awaelchli commented Jun 30, 2020 •
edited
Loading

We are aware of that it will be refactored in the future. Here is already a discussion: #1195 #1998

@ruotianluo
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@awaelchli @ruotianluo