Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeptuneLogger doesn't support fetching active experiment. #3389

Closed
blatr opened this issue Sep 7, 2020 · 4 comments
Closed

NeptuneLogger doesn't support fetching active experiment. #3389

blatr opened this issue Sep 7, 2020 · 4 comments
Labels
feature Is an improvement or enhancement help wanted Open to be worked on won't fix This will not be worked on

Comments

@blatr
Copy link
Contributor

blatr commented Sep 7, 2020

Hi!

🚀 Feature

Currently NeptuneLogger doesn't support reconnecting to active experiment. Each initialization always creates a new one and there is no option to pass existing experiment id.
However, this feature is already supported by Neptune library and actually implemented in _create_or_get_experiment() method inside NeptuneLogger class.

Proposal

Make it possible to pass optional argument experiment_id to class initialization.
With this replacement _create_or_get_experiment() function will be able to fetch existing experiment during class initialization.

If you don't mind i can make a PR with this small enhancement.

@blatr blatr added feature Is an improvement or enhancement help wanted Open to be worked on labels Sep 7, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2020

Hi! thanks for your contribution!, great first issue!

@Borda
Copy link
Member

Borda commented Sep 8, 2020

@jakubczakon mind have look? 🐰

@pitercl
Copy link
Contributor

pitercl commented Sep 9, 2020

Hi @blatr, I thinks it's a nice idea!
Please be aware, that there's already a PR in progress (#3256) that'll probably come in a superficial conflict with yours, but I don't see any actual problems with this idea.

@stale
Copy link

stale bot commented Oct 21, 2020

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions, Pytorch Lightning Team!

@stale stale bot added the won't fix This will not be worked on label Oct 21, 2020
@stale stale bot closed this as completed Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement help wanted Open to be worked on won't fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants