Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pipy badges and images not rendering #4978

Closed
edenlightning opened this issue Dec 4, 2020 · 7 comments · Fixed by #5002
Closed

Fix pipy badges and images not rendering #4978

edenlightning opened this issue Dec 4, 2020 · 7 comments · Fixed by #5002
Labels
bug Something isn't working docs Documentation related good first issue Good for newcomers help wanted Open to be worked on priority: 0 High priority task
Milestone
pl:1.1

Comments

@edenlightning
Copy link
Contributor

edenlightning commented Dec 4, 2020 •
edited by Borda
Loading

it seems that it did not work for PyPI page
see our RC - https://pypi.org/project/pytorch-lightning/1.1.0rc1
when I open the PKG-INFO I still see the original paths...

Downloaded implemented in #4250
@edenlightning edenlightning added the priority: 0 High priority task label Dec 4, 2020
@edenlightning edenlightning added this to the 1.1 milestone Dec 4, 2020
@Borda Borda added bug Something isn't working docs Documentation related good first issue Good for newcomers help wanted Open to be worked on labels Dec 4, 2020
@Borda
Copy link
Member

Borda commented Dec 4, 2020

ref: #4250 (comment)

@janhenriklambrechts
Copy link
Contributor

If you still need some help, I can look into it.

@Borda
Copy link
Member

Borda commented Dec 7, 2020

If you still need some help, I can look into it.

it would be nice, I am about to take it today too, do you have any similar experience?

@janhenriklambrechts
Copy link
Contributor

janhenriklambrechts commented Dec 7, 2020 •
edited
Loading

No similar experience but happy to dive in and learn. I might take some time getting up to speed (just like the checkpoint issue) so if it is very urgent, feel free to skip over me :]

@Borda
Copy link
Member

Borda commented Dec 7, 2020

seems we would need to upload the images somewhere on a cloud... https://stackoverflow.com/a/46875147/4521646

@janhenriklambrechts
Copy link
Contributor

seems we would need to upload the images somewhere on a cloud... https://stackoverflow.com/a/46875147/4521646

Or as an asset of this repo and just use the raw github link

@Borda
Copy link
Member

Borda commented Dec 7, 2020 •
edited
Loading

yes, but as we download them during package build time there are not in any git version (just on the fly) so we would need to upload them to some free public domain and refer them there...

so, yes, we can put a hard link to the images but not budges... :/ pypi/warehouse#5246 (comment)
well, let's try to upload it as assets and refer from the given path :]
https://github.com/actions/upload-release-asset

@Borda Borda mentioned this issue Dec 7, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working docs Documentation related good first issue Good for newcomers help wanted Open to be worked on priority: 0 High priority task
Projects
None yet
Milestone
pl:1.1
Development

Successfully merging a pull request may close this issue.

CI: update badges for release
3 participants
@Borda @janhenriklambrechts @edenlightning