Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization docs and override optimizer_step docs #5092

Closed
ananyahjha93 opened this issue Dec 11, 2020 · 1 comment · Fixed by #5095
Closed

Optimization docs and override optimizer_step docs #5092

ananyahjha93 opened this issue Dec 11, 2020 · 1 comment · Fixed by #5095
Assignees
@tchaton

Comments

@ananyahjha93
Copy link
Contributor

📚 Documentation

Optimization docs need to be updated with the correct way of overriding optimizer_step() method, which now takes in a closure as a non-optional parameter.

https://pytorch-lightning.readthedocs.io/en/latest/optimizers.html#step-optimizers-at-arbitrary-intervals
@ananyahjha93 ananyahjha93 transferred this issue from Lightning-Universe/lightning-bolts Dec 11, 2020
@ananyahjha93
Copy link
Contributor Author

@edenlightning

@tchaton tchaton mentioned this issue Dec 11, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tchaton tchaton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[hotfix] Extend Optimizer + update doc Lightning-AI/pytorch-lightning
2 participants
@ananyahjha93 @tchaton