Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor running stage routing #5660

Closed
carmocca opened this issue Jan 26, 2021 · 1 comment
Closed

Refactor running stage routing #5660

carmocca opened this issue Jan 26, 2021 · 1 comment
Labels
help wanted Open to be worked on refactor

Comments

@carmocca
Copy link
Contributor

No we can't in the current state of the codebase. Trainer.predict relies on self.trainertesting to be True for routing the code in the test part of the evaluation loop, and if we set self._running_stage = RuningStage.PREDICTING, it would route to validation and we won't gather the prediction.

I plan to properly refactor routing in a follow up PR as it is currently a big mess.

Originally posted by @tchaton in #5579 (comment)
@carmocca carmocca added help wanted Open to be worked on refactor labels Jan 26, 2021
@carmocca
Copy link
Contributor Author

Duplicate of #5593

@carmocca carmocca marked this as a duplicate of #5593 Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Open to be worked on refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carmocca