simplification over all kinds of "path" settings

[marsggbo]

I'm lost in all kinds of "path" settings, could it be more simpler?

Across the source code and examples, I find that there are many types of "path" config, such as the path in ModelCheckpoint, logger, and default_save_path in trainer.

Could you please explain these path configs in more detail? For example, if we set default_save_path, how does it influence other path configs?

[github-actions]

Hey, thanks for your contribution! Great first issue!

[hadim]

I agree this kind be confusing. I am trying to unify the callback system and also try to merge this with the loggers.

In that spirit, I have added a property in Callback to retrieve what I would call the "training base directory": https://github.com/PyTorchLightning/pytorch-lightning/pull/889/files#diff-c2e9d63e89e5e7cc3384083af905407dR29

By default, all callbacks should use this path and only use the one provided in the init of the callback if it's different than None.

Callback that write on disk should also have a prefix arguments so all the files they write would go in base_training_folder / prefix (it can be a folder or a file).

Let me know what do you think.

[Borda]

@marsggbo good suggestion, we shall keep the API simple and easy to navigate...
Would you consider sending a PR with such simplification so we may have a concrete discussion over each case?

[marsggbo]

@Borda Hello, thank you for this great project!

Actually, I'm not familiar with the code details. However, I implement a framework, namely torchline, based on pytorch-lightning. In torchline, all configuration can be set in a single yaml file by using yacs lib. I think that it may further simplify the code quantity and improve the code reusability.

To keep the path consistency, we do some preprocessing when initializing the config, refering to torchline/config/config.py.

hope it can help you.

[Borda]

Good suggestion, could you pls participate in #807?
Could we continue here with "path" so @hadim do you that #849 and #889 solves this completely?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.