Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename pl_devtools to lightning_tools #19

Closed
carmocca opened this issue Aug 31, 2022 · 5 comments · Fixed by #27
Closed

Rename pl_devtools to lightning_tools #19

carmocca opened this issue Aug 31, 2022 · 5 comments · Fixed by #27
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@carmocca
Copy link
Contributor

🚀 Feature

See title. Feel free to close if you disagree
@carmocca carmocca added enhancement New feature or request help wanted Extra attention is needed labels Aug 31, 2022
@carmocca
Copy link
Contributor Author

Related discussion: Lightning-AI/pytorch-lightning#14475 (comment)

@Borda
Copy link
Member

Borda commented Aug 31, 2022

the package name is already: https://github.com/Lightning-AI/devtools/blob/45ea7c5a594b61d4b264900fc4ed2ff459c76804/setup.py#L28
but the comment above was rather about the package scope not no name in particular

@Borda Borda mentioned this issue Aug 31, 2022
Closed
4 tasks
@carmocca
Copy link
Contributor Author

@Borda Why not go for lightning_tools directly?

Also, I would not go with lit. It's inconsistent with everything else

@carmocca carmocca changed the title Rename pl_devtools to lightning_devtools Rename pl_devtools to lightning_tools Aug 31, 2022
@akihironitta
Copy link
Contributor

+1 for lightning_tools.

@carmocca carmocca mentioned this issue Sep 2, 2022
Merged
@awaelchli
Copy link
Contributor

+1 for lightning_tools if we feel like in the future there will be more than just devtools (maybe docs utils too who knows?)
+1 for lightning_devtools if the intention is to make it super focused

@carmocca carmocca mentioned this issue Sep 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pl-devtools -> lightning_tools Lightning-AI/utilities
4 participants
@awaelchli @Borda @carmocca @akihironitta