fix: reconnect sc event loop #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunjixin
force-pushed
the
fix/sc_event_loop
branch
from
eb3c4ad to
ad577b2
Compare
AquiGorka
requested review from
walkah,
alvin-reyes,
bgins and
noryev
and removed request for
AquiGorka
alvin-reyes
reviewed
Jul 31, 2024
alvin-reyes
reviewed
Jul 31, 2024
hunjixin
force-pushed
the
fix/sc_event_loop
branch
from
3ac81ab to
2fa2cda
Compare
hunjixin
force-pushed
the
fix/sc_event_loop
branch
from
2fa2cda to
305181d
Compare
alvin-reyes
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Type Requested (choose one):
Summary
Provide a one line summary and link to any relevant references
Task/Issue reference
Closes: add_link_here
Details (optional)
Add any additional details that might help Code Reviewers digest this PR
How to test this code? (optional)
Anything else? (optional)