Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove PR title labeling #267

Merged
merged 1 commit into from
Jul 30, 2024
Merged

chore: Remove PR title labeling #267

merged 1 commit into from
Jul 30, 2024

Conversation

bgins
Copy link
Contributor

@bgins bgins commented Jul 30, 2024

Review Type Requested (choose one):

  • Glance - superficial check (from domain experts)

Summary

This pull request makes the following changes:

  • Remove PR labeling based on title

The labeling unfortunately removes existing labels. We have experimented with ytanikin/PRConventionalCommits at version v1.2.0 (#260), but found that it removed a documentation label from #265 when it ran the workflow with labeling enabled.

@bgins bgins requested a review from noryev July 30, 2024 16:47
@github-actions github-actions bot added the chore label Jul 30, 2024
Copy link
Contributor

@noryev noryev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@bgins bgins merged commit 3dd827d into main Jul 30, 2024
1 check passed
@bgins bgins deleted the bgins/chore-remove-pr-labels branch July 30, 2024 16:52
bgins added a commit that referenced this pull request Jul 30, 2024
bgins added a commit that referenced this pull request Jul 30, 2024
@bgins bgins self-assigned this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants