Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: removes gpc options check #282

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

narbs91
Copy link
Collaborator

@narbs91 narbs91 commented Aug 7, 2024

Review Type Requested (choose one):

  • Glance - superficial check (from domain experts)
  • Logic - thorough check (from everybody doing review)

Summary

This PR removes the GPC testnet check introduce through PR 138

Task/Issue reference

Closes: #272

Details (optional)

According to the issue description the GPC testnet URL is no longer in use and thus we can remove this check from the modules

How to test this code? (optional)

The code was tested by building and running it after the code changes using:

./stack run -n dev cowsay:v0.0.1 -i Message=Moo

Anything else? (optional)

@narbs91 narbs91 requested review from walkah and bgins August 7, 2024 17:42
@narbs91 narbs91 self-assigned this Aug 7, 2024
@github-actions github-actions bot added the revert label Aug 7, 2024
Copy link
Collaborator

@walkah walkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 looks like you got them all! First PR? :shipit:

@narbs91
Copy link
Collaborator Author

narbs91 commented Aug 7, 2024

🔥 looks like you got them all! First PR? :shipit:

Yessir! Hopefully I don't bring down production with this 😅

@narbs91 narbs91 merged commit 09c5518 into main Aug 7, 2024
1 check passed
@narbs91 narbs91 deleted the narbs91/revert-Add-GCP-deprecation-notice branch August 7, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] Remove GCP deprecation notice
2 participants