Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eslint 9 #17

Closed
xamoulin opened this issue Apr 23, 2024 · 11 comments
Closed

Support eslint 9 #17

xamoulin opened this issue Apr 23, 2024 · 11 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@xamoulin
Copy link

xamoulin commented Apr 23, 2024

Add support to version 9 of eslint.

@Limegrass
Copy link
Owner

Thanks for the issue. This has been in my radar, and I just hadn't got around to looking into whether the new config format was backwards compatible or not. Definitely helps to know that someone is trying to use it with ESLint 9 l, so I can start taking a look into this week when I find some time.

@Limegrass Limegrass added enhancement New feature or request help wanted Extra attention is needed labels Apr 24, 2024
@Limegrass
Copy link
Owner

I should have updated this earlier, but I took a brief look at this last week. It seems like typescript-eslint and eslint-plugin-import has yet to support ESLint 9, which makes it a bit hard to dogfood this plugin given that it seems like the new config format is not backwards compatible with the old config format, making it hard to upgrade to ESLint 9 in this package.

Holding off on working on this until the other plugins includes support.

@Crownpack07
Copy link

@Limegrass It seems the mentioned dependencies have been upgraded to support ESLint 9, is this something that you would be able to address now?

@Limegrass
Copy link
Owner

Ah, thanks for the heads up! I'll make some time to take a look into this.

@Crownpack07
Copy link

@Limegrass Do you want me to take a look at this when I have some time? We are currently using this in our application and this plugin is preventing us from upgrading to ESLint 9, so I do not mind taking a look at it if I have some spare time this week

@Limegrass
Copy link
Owner

@Crownpack07 Sorry about that! That'll be very welcome; I didn't get a chance to look into it last weekend, so I haven't had a start on it.

@Crownpack07
Copy link

I started the upgrade process, just sorting out a jest config issue post upgrade, but should be able to create a PR by end of the week if all goes well

@Crownpack07
Copy link

@Limegrass I have created a PR but it still requires a lot of refinement #18

@Limegrass
Copy link
Owner

Thanks for this. Will take a look and test this out; I'll probably have some questions just from a glance

@Limegrass
Copy link
Owner

Version 1.5.0 should add support for eslint@9. Please let me know if it doesn't work for any reason. Letting me know if it does work also helps along with closing the issue!

I'll otherwise close this issue in a week or two if I don't hear of any issues.

@Limegrass
Copy link
Owner

Looks like there's a few hundred downloads for the new version and I haven't heard anything. Worked for my own usages. Closing this out for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants