Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background alias is invalid when dmg is mounted to non-standard path #40

Open
djalmaaraujo opened this issue Aug 18, 2014 · 4 comments
Open

Comments

@djalmaaraujo
Copy link

I am trying to regenerate the background, but it's getting blank. The folder is inside the directory, I tried to change the name to see if the problem is related to cache, but after a few tries, now it is always blank.

Folder: https://www.dropbox.com/s/o32jy2tlav9nmy8/Screenshot%202014-08-18%2009.30.19.png
JSON: https://gist.github.com/66497ed36ba52f54b355
DMG generated: https://www.dropbox.com/s/rq1dgng2q3mxkm6/Screenshot%202014-08-18%2009.31.27.png

@LinusU
Copy link
Owner

LinusU commented Aug 20, 2014

Hi,

Took me some time to figure this out but here is what happens. For some reason appdmg was stopped in the middle of everything and it exited without cleanup. Most likely someone pressed ctrl + c in the terminal.

That made the mount point /Volumes/Test Title being taken but without showing it in the Finder sidebar.

The next time appdmg tries to make an image, it gets temporarily mounted onto /Volumes/Test Title 1. This shoudn't be a problem, but for some reason the link to the background fails when this happens.

So, two things should be fixed:

  • Catch SIGINT and make sure to run the cleanup steps before quitting
  • Figure out why background fails on non-predictable name, and fix it

@djalmaaraujo
Copy link
Author

@LinusU This is great. I will try to figure out some way to fix and submit a pr.

@LinusU LinusU changed the title When background png changes, no more background is attached to the DMG Background alias is invalid when dmg is mounted to non-standard path Oct 16, 2014
@Layoric
Copy link

Layoric commented Feb 15, 2015

I am also getting the same behavior described by @djalmaaraujo after a crash of the process I can no longer use the same title in the json config without getting a blank background. If I change the title, the background image works in the .dmg.

Even after npm uninstall -g appdmg and reinstall, problem still persists. A reboot of the machine seems to clear whatever is persisting that is creating this issue.

@AlicanC
Copy link

AlicanC commented Oct 7, 2015

I have had the same problem today. I think this is how it happened to me:

  • Start DMG creation.
  • Temp DMG gets mounted to "/Volumes/Test Title/".
  • Background is set to "/Volumes/Test Title/.background/background.png".
  • Creation complete.
  • Mount the DMG to test it.
  • Start another DMG creation.
  • Temp DMG gets mounted to "/Volumes/Test Title 1/".
  • Background is set to "/Volumes/Test Title 1/.background/background.png".
  • Creation complete.
  • Mount the DMG to test it.
  • Weird stuff happens.

Do you have to give the background an absolute path? Couldn't it just be ".background/background.png" instead of "/Volumes/Test Title/.background/background.png"? Maybe that would solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants