Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update request id handling on JSONRPC #6698

Closed
ishantiw opened this issue Aug 27, 2021 · 1 comment
Closed

Update request id handling on JSONRPC #6698

ishantiw opened this issue Aug 27, 2021 · 1 comment
Labels
framework type: refactoring

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Aug 27, 2021 •
edited by shuse2
Loading

Description

Currently when request.id is used, it is casted with as string. This casting needs to be removed.

https://github.com/LiskHQ/lisk-sdk/blob/feature/6554-improve-framework-architecture/framework/src/controller/request.ts#L28

action.id now called request.id is string | null | number to comply with JSONRPC 2.0, but we only expect string

Acceptance Criteria

  • Request must be compatible with JSONRPC 2.0
  • All unit tests should pass
  • All integration tests should pass
  • All functional tests should pass
@ishantiw ishantiw mentioned this issue Aug 27, 2021
Closed
@sridharmeganathan sridharmeganathan mentioned this issue Aug 29, 2021
Closed
@shuse2 shuse2 moved this to Backlog in Lisk SDK Version 6.0.0 Jan 7, 2022
@shuse2 shuse2 changed the title Action id adjusted to be string in framework Update request id handling on JSONRPC Jan 12, 2022
@shuse2
Copy link
Collaborator

shuse2 commented Dec 20, 2023

Closing this issue since this is no longer valid

@shuse2 shuse2 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
framework type: refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shuse2 @ishantiw @sridharmeganathan