Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove transaction independent verify and total spending checks #4845

Closed
shuse2 opened this issue Feb 17, 2020 · 0 comments · Fixed by #4878
Closed

Remove transaction independent verify and total spending checks #4845

shuse2 opened this issue Feb 17, 2020 · 0 comments · Fixed by #4878
Assignees
@shuse2
Labels
elements/chain
Milestone
Sprint 14

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Feb 17, 2020 •
edited
Loading

Description

With the new LIP, Establish block validity by applying transactions sequentially, block processing should remove certain verification.

Motivation

  • In order to support ordered nonce, simplifying the transaction verification is important

Acceptance Criteria

  • Remove verifyTotalSpending in lisk-chain/src/transactions/transactions_handlers.ts
  • Remove verifyTransactions in lisk-chain/src/transactions/transactions_handlers.ts (it includes timestamp check, and this can be also removed)
  • Remove all related tests to those functions
  • Check the exception case which relates to verifyTotalSpending, and create issue if necessary

Related issues

#4837
This was referenced Feb 17, 2020
Closed
Closed
@shuse2 shuse2 self-assigned this Feb 25, 2020
@shuse2 shuse2 added this to the Sprint 14 milestone Feb 25, 2020
@shuse2 shuse2 mentioned this issue Feb 25, 2020
Merged
ManuGowda added a commit that referenced this issue Feb 26, 2020
@ManuGowda
Merge pull request #4878 from LiskHQ/4845-remove_tx_validation
4a5771c 
Remove transaction independent verify and total spending checks - Closes #4845
@karmacoma karmacoma changed the title Remove individual transactions checks and total spending against the current blockchain state Remove transaction independent verify and total spending checks May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuse2 shuse2

Labels
elements/chain
Projects
None yet
Milestone
Sprint 14
Development

Successfully merging a pull request may close this issue.

Remove transaction independent verify and total spending checks - Closes #4845 LiskArchive/lisk-sdk
1 participant
@shuse2