Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not optimal on 4k/big screens #73

Closed
FFY00 opened this issue Dec 6, 2019 · 14 comments
Closed

Not optimal on 4k/big screens #73

FFY00 opened this issue Dec 6, 2019 · 14 comments

Comments

@FFY00
Copy link

FFY00 commented Dec 6, 2019

Hey, somewhat like a 1 month ago I got myself a new 32' 4K screen. This worked fine in the previous version but it's a bit problematic in the new one. The main issue is that the background does not zoom in to fit the screen, instead it repeats itself. The blur is also too big, I can notice squares, it's not smooth.

@Litarvan
Copy link
Owner

That's pretty strange, I remember it working good on my 4K monitor, do you have a photo or a screenshot ? Does it look the same in the LightDM debug mode (lightdm-webkit2-greeter command in a terminal) and in the browser ?

@FFY00
Copy link
Author

FFY00 commented Dec 14, 2019

Ah, sorry I forgot the exact symptoms when I reported it. Basically when the blur starts it adds some black lines.

@FFY00
Copy link
Author

FFY00 commented Dec 14, 2019

@Litarvan
Copy link
Owner

???? This is so strange! I do not have my 4K monitor currently but I'll try something to reproduce

@laurelmay
Copy link
Contributor

laurelmay commented Dec 14, 2019

I am able to see the same behavior. It almost looks like the same effect that is being applied to the borders/edges of the screen. It starts out as a very fine, thin black line and then thickens and blurs (as the rest of the background blurs).

I cannot see the behavior at https://litarvan.github.io/lightdm-webkit-theme-litarvan/ (even if Firefox is full-screen); however, I do see it if I run lightdm-webkit2-greeter from the terminal

@Demalpheus
Copy link

Demalpheus commented Dec 14, 2019

I'm seeing a similar issue on my screen, 3440x1440 resolution. also some of the options in the settings section are not accessible as they are drawn off scren.

Edit: The live version in full screen for my resolution has similar problems with items being off-screen

@Litarvan
Copy link
Owner

Litarvan commented Dec 14, 2019

I think i get it, lightdm-webkit-greeter does not manage the screen dpi, so on high dpi i had to use "zoom: 2.0", which is probably buggy because yay webkit-gtk, and is also too much if you have a a hi dpi resolution less than 4k

I'll have to wait until next week to have my 4k monitor available, and then i'll try to find a workaround

@FFY00
Copy link
Author

FFY00 commented Dec 14, 2019

xvfb allows you to create a virtual xorg server, you can use that to emulate an HiDpi display.

@Kage-Yami
Copy link

I'm experiencing the same issue here; not sure what else is helpful, but here's a screenshot of the issue reproduced by launching lightdm-webkit2-greeter from a terminal and configuring the same as my actual setup:

image

That test was done at 2560x1440 (Budgie Desktop - Arch Linux). Setting the resolution to 3840x2160 results in similar issues, albeit with the black line closer to the center, and a new horizontal line near the bottom. Issue is not present at 1920x1080.

@kotatsuyaki
Copy link

I got similar result as other comments at 2560x1600 (Manjaro Linux). The black line occurs only on the blurred login page and not other pages.

image
image

@TheBeardOfTruth
Copy link

I can verify the same issue running in 4K, screenshot taken with lightdm-webkit2-greeter debug mode (does not present in firefox)

Noticeable pixelation, image scaling incorrectly (the black bars... I'd assume they are the edge-fade effect), irrespecctive of the 'disable 2x scaling (large screen fix)' setting.

For the time being I'll just use a black background -- feels the most elegant solution

demonstration

@Litarvan
Copy link
Owner

Litarvan commented Jan 25, 2020

Looks like it was indeed a bug from Webkit. After struggling with my broken computer and xvfb (thanks a lot for the tip btw) I found that setting the background div position: absolute; instead of fixed, fixes the thing (for some reason).

I pushed the "fix", can someone build from master to test if it's working for him too ?

@TheBeardOfTruth
Copy link

Yeah, that seems to have fixed it.
And it fixed my busted awesomeWM icon, it's now rendering correctly again.

npm audit says there are 5 vulns, 4 of which are serious -- apparently. I'm not familiar enough with web tech to know how much stock to put into that build message but I figured I'd mention it anyway.

Screenshot:
fixed screenshot

@Litarvan
Copy link
Owner

Nice ! I'll update dependencies before releasing don't worry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants