Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reslang generates topic names that are not terraform compatible. #126

Closed
davinchia opened this issue Sep 29, 2020 · 5 comments · Fixed by #214
Closed

Reslang generates topic names that are not terraform compatible. #126

davinchia opened this issue Sep 29, 2020 · 5 comments · Fixed by #214
Labels
bug Something isn't working JiraIssueCreated

Comments

@davinchia
Copy link

Reslang currently generated topic names with . in them.

Although this is pubsub compatible, this is not terraform compatible and causes errors.

@davinchia davinchia added the bug Something isn't working label Sep 29, 2020
@cjea
Copy link
Contributor

cjea commented Oct 2, 2020

@davinchia when I run terraform plan with a topic name of a.b/some-topic-name, the plan still succeeds. Were you only seeing errors once the plan was applied?

@davinchia
Copy link
Author

I was seeing errors during the plan as well. Here's the specific error: https://github.com/LiveRamp/api-specs/pull/318#issuecomment-700881252

@cjea
Copy link
Contributor

cjea commented Oct 2, 2020

Oh, maybe this is due to the older terraform version (terraform0.12.20 in the linked comment). I think I'd rather update atlantis.yaml with a higher terraform version to see if that fixes the problem, before changing reslang output (since that would nuke + recreate infrastructure). I'll report back!

@davinchia
Copy link
Author

davinchia commented Oct 2, 2020

Perhaps. Didn't look too much into this - can help out if needed. Just lmk on slack! Thanks!

@cjea
Copy link
Contributor

cjea commented Oct 13, 2020

@davinchia now that api-specs has terraform 0.12.29, would you mind checking if atlantis still runs into the same error on the auto-generated plan for topic names?

If the problem persists, we'll either need to update to terraform 13, or change the Reslang code

@nhtzr nhtzr linked a pull request Nov 4, 2021 that will close this issue
@nhtzr nhtzr closed this as completed in #214 Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working JiraIssueCreated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants