Rename wasi target to wasip1, following the change in FPC #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix #747 .
It is mostly a straightforward rename
wasi->wasip1.Plus, 2 hacks to use the existing cross-libs with new name:
sources/installermanager.pasI added a hackif CrossOS_Target=TOS.wasip1 then s:='Wasi';, to download cross-libs from the old URL.sources/installerfpc.pasI added a hack to rename the directorywasm32-wasi->wasm32-wasip1.I do not recommend to apply these pieces of PR, I recommend to change the cross-libs layout and name on the server -> then you can likely avoid these 2 "hacks" I mentioned above and have simpler code.