Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reprocessing Issue with Llama 3 #803

Closed
Nabokov86 opened this issue Apr 23, 2024 · 6 comments
Closed

Reprocessing Issue with Llama 3 #803

Nabokov86 opened this issue Apr 23, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@Nabokov86
Copy link

Nabokov86 commented Apr 23, 2024

When using Llama 3, I've noticed that unnecessary reprocessing occurs on previously generated text.
To reproduce this issue, try generating a short piece of text couple of times and see how the processing sometimes happens.

Latest concedo_experimental.

@Nabokov86
Copy link
Author

Nabokov86 commented Apr 23, 2024

It seems like the reprocessing occurs after a new line is generated.
Screenshot from 2024-04-23

@LostRuins
Copy link
Owner

Did you by any chance enable "Trim Sentences" or "Author Note"?

@Nabokov86
Copy link
Author

No, I use default settings without trimming. So, you can't reproduce it?
saved_story.json

@LostRuins
Copy link
Owner

LostRuins commented Apr 24, 2024

Yes, I can reproduce it. Looking closer, the tokenizer is behaving weirdly. I think there is an issue with token merges.

Relevant: ggerganov#6809

You should experience a small amount of reprocessing all the way back to the previous newline. This is a bug.

@LostRuins LostRuins added the bug Something isn't working label Apr 24, 2024
@LostRuins
Copy link
Owner

LostRuins commented May 1, 2024

Hi, Should be fixed in the latest version. Remember to get freshly reconverted GGUFs

@Nabokov86
Copy link
Author

@LostRuins Thanks! Yes, it looks like it’s working now. Thank you for continuing to maintain this project, you’re awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants