Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Playlists): Implement addToLibrary and removeFromLibrary #844

Merged
merged 4 commits into from
Dec 31, 2024
Merged

feat(Playlists): Implement addToLibrary and removeFromLibrary #844

merged 4 commits into from
Dec 31, 2024

Conversation

Duell10111
Copy link
Contributor

Adds the possibility to add a external playlist to a user library.

Worked as sharm with v11, I adapted it to v12 structure. :)

LuanRT
LuanRT requested changes Dec 15, 2024
View reviewed changes
Copy link
Owner

@LuanRT LuanRT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think addToLibrary and removeFromLibrary would suit these methods better. Looks good otherwise.

@Duell10111
Copy link
Contributor Author

I think addToLibrary and removeFromLibrary would suit these methods better. Looks good otherwise.

Alright, renamed the methods. :)

Duell10111
Duell10111 commented Dec 15, 2024
View reviewed changes
Copy link
Contributor Author

@Duell10111 Duell10111 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method names changed.

@Duell10111 Duell10111 requested a review from LuanRT December 15, 2024 14:57
@LuanRT LuanRT changed the title feat: add possibility to add playlists to user library feat(playlists): Implement addToLibrary and removeFromLibrary Dec 31, 2024
@LuanRT LuanRT changed the title feat(playlists): Implement addToLibrary and removeFromLibrary feat(Playlists): Implement addToLibrary and removeFromLibrary Dec 31, 2024
@LuanRT LuanRT merged commit 48460e4 into LuanRT:main Dec 31, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Dec 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuanRT LuanRT LuanRT approved these changes

Assignees
No one assigned
Labels
core small-diff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Duell10111 @LuanRT