Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Use the ISO 3166-1 alpha-2 specification for the list of flags #52

Closed
markusgeert opened this issue May 31, 2021 · 2 comments
Closed
Labels
SPIKE need to investigate

Comments

@markusgeert
Copy link
Contributor

Currently, this library contains flags of states that are UN members, complemented by a couple of other flags which belong to disputed or undisputed territories. However, at this point, the addition of these territories seem arbitrary.

To prevent any discussion that may arise in the future about the addition of a certain flag, and to add around 50 territories which are currently missing from this library, I propose the list of ISO 3166-1 alpha-2 country codes to be used to define the body of countries and territories included in this library.

The ISO 3166-1 alpha-2 specification seems to be the de facto standard that defines countries and territories. It comprises all the countries which are currently included in the library and will add around 50 more, although some of them will not have associated flags.

@LunaGao
Copy link
Owner

LunaGao commented Jul 6, 2021

I understand and agree with you.
Regarding whether to add certain regions, it is not just a simple coding issue in many cases.
The original purpose of this library was just for developers to easily obtain the required flag. Maybe the ISO 3166-1-alpha-2 you proposed is a good solution.
Thank you very much for this suggestion. I will continue to investigate this aspect based on ISO 3166-1-alpha-2 to find a suitable solution.

@LunaGao LunaGao added the SPIKE need to investigate label Jul 6, 2021
@LunaGao
Copy link
Owner

LunaGao commented Jan 16, 2022

fixed in v6.0.0

@LunaGao LunaGao closed this as completed Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SPIKE need to investigate
Projects
None yet
Development

No branches or pull requests

2 participants