Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SummaryTables html fixes #213

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

jkrumbiegel
Copy link
Collaborator

@jkrumbiegel jkrumbiegel commented Feb 18, 2025

I tried using DocumenterVitepress for SummaryTables.jl but noticed that all the table outputs were broken. DocumenterVitepress tried to prefer the text/latex mime types without being able to render them, so I'm filtering out unknown MIME types here by giving them a priority of nothing.

Also, it turns out that just writing html into the markdown source that vitepress then processes is very prone to failures. For example double newlines break html-in-markdown parsing. Plus, vitepress complains about script tags or style tags. Using the v-html feature and escaping all the html into a javascript string literal lets us pass those snippets through untouched.

One still should not use script tags within the html because they are not reexecuted on page changes, but at least they don't completely break the build with this PR.

@lazarusA
Copy link
Collaborator

lazarusA commented Feb 18, 2025

Thanks a million. This has been a pain also for me. Ready for merge? Also, could you please add a short example to the docs, so that we can see it in action.

@jkrumbiegel
Copy link
Collaborator Author

jkrumbiegel commented Feb 18, 2025

I noticed one more problem while testing the docs example, this one should work. But this is from a fork so there will be no preview deploy.

@lazarusA
Copy link
Collaborator

Well, let's merge and see 🙂.

@lazarusA lazarusA merged commit 648b083 into LuxDL:master Feb 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants