Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svg output is broken #41

Closed
lazarusA opened this issue Feb 26, 2024 · 5 comments
Closed

svg output is broken #41

lazarusA opened this issue Feb 26, 2024 · 5 comments

Comments

@lazarusA
Copy link
Collaborator

On master, the automatic output of images for the svg format is broken. Tested on https://github.com/lazarusA/TemplateDocsVitePress.jl

@asinghvi17
Copy link
Collaborator

Should be fine after this release

@lazarusA
Copy link
Collaborator Author

Output is back but, now the svg doesn't re-scales to the div width. In mobile the figures overflow to the right. Also, the literate example works locally but no online, no figure 😢.

@asinghvi17
Copy link
Collaborator

That is a problem. Should it be wrapped in an image tag?

@lazarusA
Copy link
Collaborator Author

yes. It should be wrapped with img tag. That's how is working now in BeautifulMakie. Well, how it was working with version 0 :D

@asinghvi17
Copy link
Collaborator

I was trying to save as few files as possible :D

but it seems as though we can pass it as base64...I'll try to do that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants