Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More API updates #696

Merged
merged 2 commits into from
Jun 11, 2024
Merged

More API updates #696

merged 2 commits into from
Jun 11, 2024

Conversation

avik-pal
Copy link
Member

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Benchmark suite Current: 006b710 Previous: f7f4551 Ratio
Dense(2 => 2)/cpu/reverse/ReverseDiff (compiled)/(2, 128) 3620.5 ns 3700.75 ns 0.98
Dense(2 => 2)/cpu/reverse/Zygote/(2, 128) 7208.5 ns 7173.416666666666 ns 1.00
Dense(2 => 2)/cpu/reverse/Tracker/(2, 128) 20999 ns 21129 ns 0.99
Dense(2 => 2)/cpu/reverse/ReverseDiff/(2, 128) 9678 ns 9760.75 ns 0.99
Dense(2 => 2)/cpu/reverse/Flux/(2, 128) 8940.375 ns 9085 ns 0.98
Dense(2 => 2)/cpu/reverse/SimpleChains/(2, 128) 4460.875 ns 4523.5 ns 0.99
Dense(2 => 2)/cpu/reverse/Enzyme/(2, 128) 1168 ns 1158.1818181818182 ns 1.01
Dense(2 => 2)/cpu/forward/NamedTuple/(2, 128) 1167.9083969465648 ns 1117.313725490196 ns 1.05
Dense(2 => 2)/cpu/forward/ComponentArray/(2, 128) 1189.4242424242425 ns 1190.6204379562043 ns 1.00
Dense(2 => 2)/cpu/forward/Flux/(2, 128) 1811.7551020408164 ns 1784.6923076923076 ns 1.02
Dense(2 => 2)/cpu/forward/SimpleChains/(2, 128) 180.16806722689077 ns 180.12934631432546 ns 1.00
Dense(20 => 20)/cpu/reverse/ReverseDiff (compiled)/(20, 128) 17312 ns 17322 ns 1.00
Dense(20 => 20)/cpu/reverse/Zygote/(20, 128) 16961 ns 17012 ns 1.00
Dense(20 => 20)/cpu/reverse/Tracker/(20, 128) 39554 ns 39274 ns 1.01
Dense(20 => 20)/cpu/reverse/ReverseDiff/(20, 128) 29575 ns 29480 ns 1.00
Dense(20 => 20)/cpu/reverse/Flux/(20, 128) 20198 ns 21670.5 ns 0.93
Dense(20 => 20)/cpu/reverse/SimpleChains/(20, 128) 17473 ns 17322 ns 1.01
Dense(20 => 20)/cpu/reverse/Enzyme/(20, 128) 4365.285714285715 ns 4363.857142857143 ns 1.00
Dense(20 => 20)/cpu/forward/NamedTuple/(20, 128) 3902.375 ns 3877.125 ns 1.01
Dense(20 => 20)/cpu/forward/ComponentArray/(20, 128) 3972.5 ns 3962.375 ns 1.00
Dense(20 => 20)/cpu/forward/Flux/(20, 128) 4912.142857142857 ns 4940.571428571428 ns 0.99
Dense(20 => 20)/cpu/forward/SimpleChains/(20, 128) 1657.1 ns 1673.2 ns 0.99
Conv((3, 3), 3 => 3)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 3, 128) 50155976 ns 49957369 ns 1.00
Conv((3, 3), 3 => 3)/cpu/reverse/Zygote/(64, 64, 3, 128) 58224304 ns 57581648 ns 1.01
Conv((3, 3), 3 => 3)/cpu/reverse/Tracker/(64, 64, 3, 128) 112124788 ns 112009767.5 ns 1.00
Conv((3, 3), 3 => 3)/cpu/reverse/ReverseDiff/(64, 64, 3, 128) 108072819 ns 106965049 ns 1.01
Conv((3, 3), 3 => 3)/cpu/reverse/Flux/(64, 64, 3, 128) 108313728 ns 105768801 ns 1.02
Conv((3, 3), 3 => 3)/cpu/reverse/SimpleChains/(64, 64, 3, 128) 12353903.5 ns 11747527 ns 1.05
Conv((3, 3), 3 => 3)/cpu/reverse/Enzyme/(64, 64, 3, 128) 17985557 ns 17741547 ns 1.01
Conv((3, 3), 3 => 3)/cpu/forward/NamedTuple/(64, 64, 3, 128) 7092918 ns 7001933.5 ns 1.01
Conv((3, 3), 3 => 3)/cpu/forward/ComponentArray/(64, 64, 3, 128) 7072285 ns 7000243.5 ns 1.01
Conv((3, 3), 3 => 3)/cpu/forward/Flux/(64, 64, 3, 128) 18777626 ns 18531441 ns 1.01
Conv((3, 3), 3 => 3)/cpu/forward/SimpleChains/(64, 64, 3, 128) 6449416 ns 6394361 ns 1.01
vgg16/cpu/reverse/Zygote/(32, 32, 3, 16) 755965945 ns 727979542 ns 1.04
vgg16/cpu/reverse/Zygote/(32, 32, 3, 64) 2612943021 ns 2579077526 ns 1.01
vgg16/cpu/reverse/Zygote/(32, 32, 3, 2) 147224160 ns 131352834.5 ns 1.12
vgg16/cpu/reverse/Tracker/(32, 32, 3, 16) 979499881 ns 969586753 ns 1.01
vgg16/cpu/reverse/Tracker/(32, 32, 3, 64) 3636596128 ns 3263278361 ns 1.11
vgg16/cpu/reverse/Tracker/(32, 32, 3, 2) 241987648.5 ns 226498384 ns 1.07
vgg16/cpu/reverse/Flux/(32, 32, 3, 16) 730131690.5 ns 873641593 ns 0.84
vgg16/cpu/reverse/Flux/(32, 32, 3, 64) 3217207323 ns 3046764407 ns 1.06
vgg16/cpu/reverse/Flux/(32, 32, 3, 2) 133657243.5 ns 131007272.5 ns 1.02
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 16) 196632127 ns 174047082 ns 1.13
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 64) 655807247 ns 645727264.5 ns 1.02
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 2) 45773534 ns 45534194 ns 1.01
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 16) 166521523.5 ns 164324255 ns 1.01
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 64) 636909498 ns 642792641 ns 0.99
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 2) 30518906 ns 29977065 ns 1.02
vgg16/cpu/forward/Flux/(32, 32, 3, 16) 228545631 ns 201738658 ns 1.13
vgg16/cpu/forward/Flux/(32, 32, 3, 64) 909087816 ns 918807028 ns 0.99
vgg16/cpu/forward/Flux/(32, 32, 3, 2) 38124237 ns 40275483 ns 0.95
Conv((3, 3), 64 => 64)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 64, 128) 1314252462.5 ns 1293544406.5 ns 1.02
Conv((3, 3), 64 => 64)/cpu/reverse/Zygote/(64, 64, 64, 128) 1879794792.5 ns 1861728870 ns 1.01
Conv((3, 3), 64 => 64)/cpu/reverse/Tracker/(64, 64, 64, 128) 2468781585 ns 2468521111 ns 1.00
Conv((3, 3), 64 => 64)/cpu/reverse/ReverseDiff/(64, 64, 64, 128) 2614330051 ns 2631348316 ns 0.99
Conv((3, 3), 64 => 64)/cpu/reverse/Flux/(64, 64, 64, 128) 1931893594 ns 1895453908 ns 1.02
Conv((3, 3), 64 => 64)/cpu/reverse/Enzyme/(64, 64, 64, 128) 559431427 ns 565985350 ns 0.99
Conv((3, 3), 64 => 64)/cpu/forward/NamedTuple/(64, 64, 64, 128) 334300716.5 ns 321376035 ns 1.04
Conv((3, 3), 64 => 64)/cpu/forward/ComponentArray/(64, 64, 64, 128) 331102391 ns 320502632 ns 1.03
Conv((3, 3), 64 => 64)/cpu/forward/Flux/(64, 64, 64, 128) 371162812 ns 486344616 ns 0.76
Conv((3, 3), 1 => 1)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 1, 128) 11747280 ns 11994505.5 ns 0.98
Conv((3, 3), 1 => 1)/cpu/reverse/Zygote/(64, 64, 1, 128) 17877355 ns 17906521 ns 1.00
Conv((3, 3), 1 => 1)/cpu/reverse/Tracker/(64, 64, 1, 128) 19365194.5 ns 19110550.5 ns 1.01
Conv((3, 3), 1 => 1)/cpu/reverse/ReverseDiff/(64, 64, 1, 128) 23879500 ns 23813093 ns 1.00
Conv((3, 3), 1 => 1)/cpu/reverse/Flux/(64, 64, 1, 128) 17916538 ns 17831210 ns 1.00
Conv((3, 3), 1 => 1)/cpu/reverse/SimpleChains/(64, 64, 1, 128) 1171369 ns 1157282 ns 1.01
Conv((3, 3), 1 => 1)/cpu/reverse/Enzyme/(64, 64, 1, 128) 5825084 ns 5758236.5 ns 1.01
Conv((3, 3), 1 => 1)/cpu/forward/NamedTuple/(64, 64, 1, 128) 2068500 ns 2047310.5 ns 1.01
Conv((3, 3), 1 => 1)/cpu/forward/ComponentArray/(64, 64, 1, 128) 2053066 ns 2030949 ns 1.01
Conv((3, 3), 1 => 1)/cpu/forward/Flux/(64, 64, 1, 128) 2079156 ns 2077663 ns 1.00
Conv((3, 3), 1 => 1)/cpu/forward/SimpleChains/(64, 64, 1, 128) 198560 ns 201106 ns 0.99
Dense(200 => 200)/cpu/reverse/ReverseDiff (compiled)/(200, 128) 293789 ns 293318 ns 1.00
Dense(200 => 200)/cpu/reverse/Zygote/(200, 128) 267480 ns 265260.5 ns 1.01
Dense(200 => 200)/cpu/reverse/Tracker/(200, 128) 372696 ns 366414 ns 1.02
Dense(200 => 200)/cpu/reverse/ReverseDiff/(200, 128) 412611 ns 408473 ns 1.01
Dense(200 => 200)/cpu/reverse/Flux/(200, 128) 275945 ns 273792 ns 1.01
Dense(200 => 200)/cpu/reverse/SimpleChains/(200, 128) 412350 ns 406058 ns 1.02
Dense(200 => 200)/cpu/reverse/Enzyme/(200, 128) 83627 ns 83516 ns 1.00
Dense(200 => 200)/cpu/forward/NamedTuple/(200, 128) 82334 ns 81513 ns 1.01
Dense(200 => 200)/cpu/forward/ComponentArray/(200, 128) 82625 ns 81592 ns 1.01
Dense(200 => 200)/cpu/forward/Flux/(200, 128) 87624 ns 86632 ns 1.01
Dense(200 => 200)/cpu/forward/SimpleChains/(200, 128) 104495 ns 104725 ns 1.00
Conv((3, 3), 16 => 16)/cpu/reverse/ReverseDiff (compiled)/(64, 64, 16, 128) 206526267 ns 199636923 ns 1.03
Conv((3, 3), 16 => 16)/cpu/reverse/Zygote/(64, 64, 16, 128) 325189660 ns 324677516.5 ns 1.00
Conv((3, 3), 16 => 16)/cpu/reverse/Tracker/(64, 64, 16, 128) 432710461 ns 437484335 ns 0.99
Conv((3, 3), 16 => 16)/cpu/reverse/ReverseDiff/(64, 64, 16, 128) 475197527 ns 526587672 ns 0.90
Conv((3, 3), 16 => 16)/cpu/reverse/Flux/(64, 64, 16, 128) 393647341 ns 410366601.5 ns 0.96
Conv((3, 3), 16 => 16)/cpu/reverse/SimpleChains/(64, 64, 16, 128) 341927878 ns 323744332.5 ns 1.06
Conv((3, 3), 16 => 16)/cpu/reverse/Enzyme/(64, 64, 16, 128) 100683335.5 ns 102515100.5 ns 0.98
Conv((3, 3), 16 => 16)/cpu/forward/NamedTuple/(64, 64, 16, 128) 44219653.5 ns 43799747 ns 1.01
Conv((3, 3), 16 => 16)/cpu/forward/ComponentArray/(64, 64, 16, 128) 43875022 ns 43534417 ns 1.01
Conv((3, 3), 16 => 16)/cpu/forward/Flux/(64, 64, 16, 128) 59365597 ns 63896063 ns 0.93
Conv((3, 3), 16 => 16)/cpu/forward/SimpleChains/(64, 64, 16, 128) 28384318 ns 28176419 ns 1.01
Dense(2000 => 2000)/cpu/reverse/ReverseDiff (compiled)/(2000, 128) 19414216 ns 18931882 ns 1.03
Dense(2000 => 2000)/cpu/reverse/Zygote/(2000, 128) 19719777 ns 19487991 ns 1.01
Dense(2000 => 2000)/cpu/reverse/Tracker/(2000, 128) 23403846 ns 23372438.5 ns 1.00
Dense(2000 => 2000)/cpu/reverse/ReverseDiff/(2000, 128) 24125480 ns 24063046.5 ns 1.00
Dense(2000 => 2000)/cpu/reverse/Flux/(2000, 128) 19641373 ns 19611168.5 ns 1.00
Dense(2000 => 2000)/cpu/reverse/Enzyme/(2000, 128) 6537235 ns 6520318 ns 1.00
Dense(2000 => 2000)/cpu/forward/NamedTuple/(2000, 128) 6527367 ns 6498792 ns 1.00
Dense(2000 => 2000)/cpu/forward/ComponentArray/(2000, 128) 6519883 ns 6477998.5 ns 1.01
Dense(2000 => 2000)/cpu/forward/Flux/(2000, 128) 6483175 ns 6511497 ns 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@avik-pal avik-pal force-pushed the ap/more_boltz_updates branch 3 times, most recently from fe58cfb to 1e3d6a2 Compare June 11, 2024 06:20
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.98%. Comparing base (f7f4551) to head (1e3d6a2).

Current head 1e3d6a2 differs from pull request most recent head 006b710

Please upload reports for the commit 006b710 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
- Coverage   87.34%   86.98%   -0.36%     
==========================================
  Files          50       50              
  Lines        2505     2505              
==========================================
- Hits         2188     2179       -9     
- Misses        317      326       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal force-pushed the ap/more_boltz_updates branch from 1e3d6a2 to 006b710 Compare June 11, 2024 07:34
@avik-pal avik-pal merged commit edda7ec into main Jun 11, 2024
16 of 18 checks passed
@avik-pal avik-pal deleted the ap/more_boltz_updates branch June 11, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant