Wrong algorithm for calculating server TPS

[DGCK81LNN]

Minecraft-Console-Client/MinecraftClient/McClient.cs

Lines 3307 to 3346 in 27e6643

	/// <summary>
	/// Called when server sent a Time Update packet.
	/// </summary>
	/// <param name="WorldAge"></param>
	/// <param name="TimeOfDay"></param>
	public void OnTimeUpdate(long WorldAge, long TimeOfDay)
	{
	// TimeUpdate sent every server tick hence used as timeout detect
	UpdateKeepAlive();
	// calculate server tps
	if (lastAge != 0)
	{
	DateTime currentTime = DateTime.Now;
	long tickDiff = WorldAge - lastAge;
	Double tps = tickDiff / (currentTime - lastTime).TotalSeconds;
	lastAge = WorldAge;
	lastTime = currentTime;
	if (tps <= 20 && tps > 0)
	{
	// calculate average tps
	if (tpsSamples.Count >= maxSamples)
	{
	// full
	sampleSum -= tpsSamples[0];
	tpsSamples.RemoveAt(0);
	}
	tpsSamples.Add(tps);
	sampleSum += tps;
	averageTPS = sampleSum / tpsSamples.Count;
	serverTPS = tps;
	DispatchBotEvent(bot => bot.OnServerTpsUpdate(tps));
	}
	}
	else
	{
	lastAge = WorldAge;
	lastTime = DateTime.Now;
	}
	DispatchBotEvent(bot => bot.OnTimeUpdate(WorldAge, TimeOfDay));
	}

The timing of time update packets is not perfect, so although the server runs at 20.0 TPS, the quotient of ticks to elapsed seconds between time updates floats around 20.0, sometimes higher than that and sometimes lower. If you entirely exclude "instantaneous" TPS samples above 20.0, the calculated average TPS is virtually always less than 20.