Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend assert_allclose instead of assert_almost_equal #171

Open
IAlibay opened this issue Sep 24, 2021 · 1 comment
Open

Recommend assert_allclose instead of assert_almost_equal #171

IAlibay opened this issue Sep 24, 2021 · 1 comment

Comments

@IAlibay
Copy link
Member

IAlibay commented Sep 24, 2021

See MDAnalysis/mdanalysis#3425 (comment)

We probably should change our base recommendation in the userguide to use assert_allclose?

@tylerjereddy
Copy link
Member

Not sure if it will be deprecated anytime soon--I imagine it is used in thousands/millions of lines of test code, but maybe doesn't hurt to be consistent with latest recommendation yeah.

I don't know if I'd advocate for mass replacement yet, but perhaps just a suggestion for new code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants