Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate encore in favour of mdaencore #4274

Open
IAlibay opened this issue Sep 3, 2023 · 7 comments
Open

Deprecate encore in favour of mdaencore #4274

IAlibay opened this issue Sep 3, 2023 · 7 comments
Assignees
Labels
Component-Analysis deprecation Deprecated functionality to give advance warning for API changes. MDAKit suitable for MDAKit remove-3.0 deprecated and remove in release 3.0
Milestone

Comments

@IAlibay
Copy link
Member

IAlibay commented Sep 3, 2023

The encore code has been turned into a separate mdakit. We should deprecate it from core with the aim of removing in 3.0.

@orbeckst orbeckst added Component-Analysis deprecation Deprecated functionality to give advance warning for API changes. remove-3.0 deprecated and remove in release 3.0 MDAKit suitable for MDAKit labels Oct 2, 2023
@IAlibay IAlibay assigned IAlibay and unassigned ianmkenney Jan 5, 2024
@orbeckst
Copy link
Member

Are we going to remove the code and replace with mdaencore until 3.0 (as we did for hole2, psa, etc)?

@IAlibay
Copy link
Member Author

IAlibay commented Feb 10, 2024

Probably? I think we're still missing a set of wheels that are fully compatible with the current status of MDA though, might need to get that done first.

@orbeckst
Copy link
Member

Deprecation should be added for 2.8.0, given that we keep sending people over to mdaencore when they open issues here.

@orbeckst
Copy link
Member

(Even if we don't replace it with the kit.)

@IAlibay
Copy link
Member Author

IAlibay commented Mar 30, 2024

I think we're just missing the CF migration, I'll add it to my to-do list for later in the month.

@fiona-naughton fiona-naughton self-assigned this Oct 14, 2024
@fiona-naughton
Copy link
Contributor

I started working on this assuming we can go the replace code with the mdakit route, but checking first @IAlibay were you able to the CF stuff? (otherwise I can just stick to adding deprecation messages for now)

@fiona-naughton
Copy link
Contributor

Following some discussion, given that mdaencore is a bit more complicated and that it would be nice to get something in before the upcoming 2.8.0 release, I'll go with adding warnings for now.

@fiona-naughton fiona-naughton added this to the Release 2.8.0 milestone Oct 18, 2024
This was referenced Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-Analysis deprecation Deprecated functionality to give advance warning for API changes. MDAKit suitable for MDAKit remove-3.0 deprecated and remove in release 3.0
Projects
None yet
Development

No branches or pull requests

4 participants