Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toollabs service needs to be productionized #3

Open
adamwight opened this issue Jun 25, 2016 · 4 comments
Open

toollabs service needs to be productionized #3

adamwight opened this issue Jun 25, 2016 · 4 comments

Comments

@adamwight
Copy link
Contributor

What a great project, thank you for writing this!

I noticed that the extension makes calls to a wmflabs service. That's fine for prototyping, but production wikis can't rely on labs services because of uptime and security concerns.

The toollabs code will need to go through code and security review--please let me know where the code lives and I'll try to help start that process.

Thank you!

@adamwight
Copy link
Contributor Author

Oops! I see you already linked to the service code:
https://github.com/Wikimedia-TW/han3_ji7_tsoo1_kian3_WM

@MGdesigner
Copy link
Owner

Yes, it is. Welcome. :)

Start point of the server program is src/idsrend/services/IDSrendServlet.java It's a java servlet. Now Working on tomcat of the toollab server.

@samwilson
Copy link

It may be difficult to get the tool into production, due to the higher requirements for security etc.

Another possibility is to continue using Tool Labs but to add a caching mechanism to this extension so that if Tool Labs is not available, image display is not broken. This wouldn't work for editing, but at least would remove calls to tools.wmflabs.org for readers.

Also, now that https://phabricator.wikimedia.org/T148693 is open, should we close this issue and continue discussion over there? :-)

@MGdesigner
Copy link
Owner

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants