Redundant typeof check

[kunal-kushwaha]

Redundant typeof check in jest-cli/src/cli/index.ts in readResultsAndExit

jest/packages/jest-cli/src/cli/index.ts

Line 121 in a35b9cc

if (typeof code === 'number' && code !== 0) {

Not a major issue, feedback required

[sauravhiremath]

@kunal-kushwaha Yeah, it does seem to do a redundant check here. We can include this fix too, in the main PR #6

// Here testFailureExitCode has type as number
const code = !result || result.success ? 0 : globalConfig.testFailureExitCode;

// ✗✗ The typeof code === 'number' check looks redundant to me, as explained above ✗✗
if (typeof code === 'number' && code !== 0) { ... }

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.