Backtrack / revert all 2.4.x Logs development #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paulo: I do not agree with this. I'm only doing it because I have no choice. I already have a solution which works better than it. So I'm crediting the person who is most responsible for this as the commit author. David. It represents strictly and exactly the result of: git checkout 1fcdb29 -- src/Components/Logs/ Which I was ordered to do.
quirinpa
force-pushed
the
FP-3084-fleetboard-migrate-logs-solution-from-2-3-to-2-4
branch
from
889b287 to
097a351
Compare
Also crediting David, since it's part of those changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FP-3084: Fleetboard - Migrate Logs solution from 2.3 to 2.4
I do not agree with this. I'm only doing it because I have no choice.
I already have a solution which works better than it.
So I'm crediting the person who is most responsible for this as the
commit author. David.
It represents exactly this:
This does exactly what the task asks. Not more, not less.
So I'm undrafting this now.
I've argued against this course of action as much as I could, as I'm aware the team will probably be reluctant to restore our 2.4.x work.