Some cleanup of structure, tests, CI #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cortner
commented
Jun 10, 2024
cortner
commented
- fixed CI to test on Julia 1.9 and 1.10 only.
- Got rid of sub-modules, there seems no point given how small the project is and it just complicated importing and exporting of functions
- simplified test infrastructure
added 2 commits
June 10, 2024 16:00
|
@tinatorabi -- ready to take a look at this. There is more cleanup to be done, which we can do in separate PRs though. |
|
Given this seems to be working, I suggest to add documentation in the README only for now and then we tag v0.0.1 asap. Once tagged we can use version control for running final tests for the paper and then integrate this into ACEfit ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.