fix(PLT-4441): update thrown errors

MacPaw · Aug 12, 2021 · 9a75f81 · 9a75f81
1 parent 8927de7
commit 9a75f81
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/composer.json b/composer.json
@@ -27,7 +27,6 @@
     "license": "MIT",
     "require": {
         "php": "^7.4 || ^8.0",
-        "ext-json": "*",
         "symfony/messenger": "^4.4 || ^5.0",
         "behat/behat": "^3.0",
         "symfony/serializer": "^5.0"

diff --git a/phpcs.xml.dist b/phpcs.xml.dist
@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <ruleset name="Platform-Mail-Service-Api">
-    <description>The coding standard of Platform-Mail-Service-Api package</description>
+    <description>The coding standard of MessengerBehatContext package</description>
     <arg value="p" />
 
     <config name="ignore_warnings_on_exit" value="1" />

diff --git a/src/Context/MessengerContext.php b/src/Context/MessengerContext.php
@@ -35,16 +35,19 @@ public function busShouldContainMessageWithJson(string $busName, PyStringNode $e
         $expectedMessage = $this->decodeExpectedJson($expectedMessage);
 
         $transport = $this->getMessengerTransportByName($busName);
+        $actualMessageList = [];
         foreach ($transport->get() as $envelope) {
             $actualMessage = $this->convertToArray($envelope->getMessage());
             if ($this->isArraysSimilar($actualMessage, $expectedMessage)) {
                 return;
             }
+
+            $actualMessageList[] = $actualMessage;
         }
 
         throw new Exception(
             sprintf(
-                'The transport doesn\'t contain message with JSON: %s',
+                'The transport doesn\'t contain message with such JSON, actual messages: %s',
                 $this->getPrettyJson($expectedMessage)
             )
         );
@@ -62,16 +65,19 @@ public function busShouldContainMessageWithJsonAndVariableFields(
         $expectedMessage = $this->decodeExpectedJson($expectedMessage);
 
         $transport = $this->getMessengerTransportByName($busName);
+        $actualMessageList = [];
         foreach ($transport->get() as $envelope) {
             $actualMessage = $this->convertToArray($envelope->getMessage());
             if ($this->isArraysSimilar($actualMessage, $expectedMessage, $variableFields)) {
                 return;
             }
+
+            $actualMessageList[] = $actualMessage;
         }
 
         throw new Exception(
             sprintf(
-                'The transport doesn\'t contain message with JSON: %s',
+                'The transport doesn\'t contain message with such JSON, actual messages: %s',
                 $this->getPrettyJson($expectedMessage)
             )
         );