Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): create integration test framework #32

Merged
merged 56 commits into from
Apr 19, 2021
Merged

chore(test): create integration test framework #32

merged 56 commits into from
Apr 19, 2021

Conversation

brodrigu
Copy link
Member

@brodrigu brodrigu commented Apr 14, 2021 •
edited by iamnewton
Loading

TODO:

  • Setup integration test framework
  • Call integration tests in GitHub actions

Fixes: #37

@brodrigu brodrigu requested a review from iamnewton as a code owner April 14, 2021 16:45
github-actions[bot]
github-actions bot reviewed Apr 14, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @! We really appreciate you taking the time to help out with this PR. The collaborators on this project attempt to help as many people as possible, but we are a limited number of volunteers, so it is possible that this will not be addressed as swiftly. Your patience is much appreciated and we will get back to you as quickly as possible.

@brodrigu brodrigu marked this pull request as draft April 14, 2021 16:45
@iamnewton iamnewton added this to the Implementation milestone Apr 14, 2021
@iamnewton iamnewton linked an issue Apr 14, 2021 that may be closed by this pull request
Create integration test for joinAdInterestGroup #21
Closed
iamnewton
iamnewton reviewed Apr 14, 2021
View reviewed changes
src/test-utils.js Outdated Show resolved Hide resolved
@iamnewton iamnewton changed the title WIP: IG happy path tests chore(tests): Interest Groups integrations Apr 14, 2021
iamnewton
iamnewton suggested changes Apr 14, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
integration/www/index.html Outdated Show resolved Hide resolved
integration/www/index.html Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
integration/interest-groups.test.js Outdated Show resolved Hide resolved
integration/interest-groups.test.js Outdated Show resolved Hide resolved
integration/jest-integration-test.config.js Outdated Show resolved Hide resolved
@iamnewton iamnewton changed the title chore(tests): Interest Groups integrations chore(test): create Interest Group integration tests framework Apr 18, 2021
@iamnewton iamnewton changed the title chore(test): create Interest Group integration tests framework chore(test): create integration test framework Apr 18, 2021
@iamnewton
Copy link
Contributor

iamnewton commented Apr 18, 2021 •
edited
Loading

@brodrigu I updated the lib to use rollup for distribution. This gets rid of the experimental node abilities and changes the export in PR #35.

@iamnewton iamnewton added the feat New feature or request label Apr 18, 2021
@iamnewton
Copy link
Contributor

I think this PR is ready for review. We should use this for the initial integration test framework and then we can both write further tests as needed.

@brodrigu brodrigu marked this pull request as ready for review April 19, 2021 17:01
@brodrigu
Copy link
Member Author

@iamnewton These changes are fine. Looks like you still have changes requested here, so please approve and merge at your leisure.

@iamnewton iamnewton merged commit 2538baf into interest-groups Apr 19, 2021
@iamnewton iamnewton deleted the ig-happy-path-tests branch April 19, 2021 17:20
iamnewton added a commit that referenced this pull request Apr 19, 2021
@iamnewton @brodrigu @dependabot
feat: create interest groups (#30)
0ef68ca 
* chore(docs): remove tech spec in favor of wiki

* chore(test): set up unit tests

* chore: fix Jest to support ES Modules

* chore: set required node version

* chore: fix busted return tests

* feat: `joinAdInterestGroup` & `leaveAdInterestGroup` functions (#31)

* feat: initial checks for function parameters

* fix: validate util passing incorrect arg

* chore: add utils unit tests

* fix: avoid calculating ms per day as per feedback

* chore: clean up error message for clarity as per feedback

* chore: clean up test language

* chore: remove stub function

* chore: remove all constants calculations

* fix: import using relative path with file suffix

* chore: add in jsdocs

* chore: remove unnecessary constants abstraction file

* chore: move tests out of source directory

* chore: ignore mocks file from tests

* chore: move unit tests to subdirectory

* chore: create API docs

* fix: main exports require file suffix

* chore: rename dir to match github standards

* feat: interest group storage helpers (#35)

* feat: create helpers for indexed db

* chore: turn off eslint console warnings

* feat: add in dist task with rollup

* chore: fix async tests

* chore: comment out consoles

* chore: remove deps

* chore: remove another dep

* chore: jest is stupid and requires this empty file for some reason

* chore: remove node 12 from tests

* chore: add in babel config for CI

* chore: fix the tests

* chore: remove unneeded babel config file

* chore: update docs

* chore: add in utils README

* chore: add language highlights to README

* chore(test): create integration test framework (#32)

Co-authored-by: Newton Koumantzelis <[email protected]>

* chore(deps-dev): bump @theholocron/jest-preset from 0.2.3 to 0.3.0 (#38)

Bumps [@theholocron/jest-preset](https://github.com/the-holocron/threepio) from 0.2.3 to 0.3.0.
- [Release notes](https://github.com/the-holocron/threepio/releases)
- [Commits](https://github.com/the-holocron/threepio/compare/@theholocron/[email protected]...@theholocron/[email protected])

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: update package

* chore: fix actions names

* chore: add coverage reports

* chore: fix actions

* chore: fix test job

* chore: tweak coverage directory

* chore: fix coverage report

Co-authored-by: Brad Rodriguez <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@iamnewton iamnewton iamnewton approved these changes

Assignees

@brodrigu brodrigu

Labels
feat New feature or request
Projects
None yet
Milestone
Implementation
Development

Successfully merging this pull request may close these issues.

Create integration test for joinAdInterestGroup
2 participants
@brodrigu @iamnewton