feat: interest group storage helpers #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good, but test fail due to import issues which we should resolve before merging. |
added 13 commits
April 16, 2021 14:53
iamnewton
pushed a commit
that referenced
this pull request
Apr 18, 2021
* interest-groups: feat: interest group storage helpers (#35) chore: rename dir to match github standards
iamnewton
pushed a commit
that referenced
this pull request
Apr 18, 2021
* ig-happy-path-tests: chore: fix tests by fixing node version chore: console some errors on CI chore: ditch window? fix: remove destructure chore: fix integration tests actions fix: merge in new output files feat: interest group storage helpers (#35) chore: rename dir to match github standards
2 tasks
iamnewton
added a commit
that referenced
this pull request
Apr 19, 2021
* chore(docs): remove tech spec in favor of wiki * chore(test): set up unit tests * chore: fix Jest to support ES Modules * chore: set required node version * chore: fix busted return tests * feat: `joinAdInterestGroup` & `leaveAdInterestGroup` functions (#31) * feat: initial checks for function parameters * fix: validate util passing incorrect arg * chore: add utils unit tests * fix: avoid calculating ms per day as per feedback * chore: clean up error message for clarity as per feedback * chore: clean up test language * chore: remove stub function * chore: remove all constants calculations * fix: import using relative path with file suffix * chore: add in jsdocs * chore: remove unnecessary constants abstraction file * chore: move tests out of source directory * chore: ignore mocks file from tests * chore: move unit tests to subdirectory * chore: create API docs * fix: main exports require file suffix * chore: rename dir to match github standards * feat: interest group storage helpers (#35) * feat: create helpers for indexed db * chore: turn off eslint console warnings * feat: add in dist task with rollup * chore: fix async tests * chore: comment out consoles * chore: remove deps * chore: remove another dep * chore: jest is stupid and requires this empty file for some reason * chore: remove node 12 from tests * chore: add in babel config for CI * chore: fix the tests * chore: remove unneeded babel config file * chore: update docs * chore: add in utils README * chore: add language highlights to README * chore(test): create integration test framework (#32) Co-authored-by: Newton Koumantzelis <[email protected]> * chore(deps-dev): bump @theholocron/jest-preset from 0.2.3 to 0.3.0 (#38) Bumps [@theholocron/jest-preset](https://github.com/the-holocron/threepio) from 0.2.3 to 0.3.0. - [Release notes](https://github.com/the-holocron/threepio/releases) - [Commits](https://github.com/the-holocron/threepio/compare/@theholocron/[email protected]...@theholocron/[email protected]) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: update package * chore: fix actions names * chore: add coverage reports * chore: fix actions * chore: fix test job * chore: tweak coverage directory * chore: fix coverage report Co-authored-by: Brad Rodriguez <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a storage mechanism for interest groups within
IndexedDB.Screenshots (optional)
N/A
Additional context (optional)
Tech Spec: https://github.com/MagniteEngineering/fledge.polyfill/wiki/Technical-Specification:-Interest-Groups#internal-functions
Checklist
Have you considered all of the following?
Please confirm by checking off each item to ensure you've considered it:
Fixes: #25, #26