feat: rendering the winning ad #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
==========================================
- Coverage 64.45% 60.52% -3.94%
==========================================
Files 9 12 +3
Lines 166 266 +100
Branches 30 87 +57
==========================================
+ Hits 107 161 +54
- Misses 47 76 +29
- Partials 12 29 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brodrigu
reviewed
Apr 27, 2021
brodrigu
reviewed
Apr 27, 2021
brodrigu
reviewed
Apr 27, 2021
| iframe.id = `fledge-auction-${source.id}`; | ||
| iframe.src = source.bid?.render; | ||
| iframe.scrolling = 'no'; | ||
| iframe.style.borderWidth = 0; |
There was a problem hiding this comment.
what size is the iframe here? we might need to set the dimensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The feature branch for rendering the winning ad's creative within the Fledge API.
Screenshots (optional)
N/A
Additional context (optional)
Tech Spec: https://github.com/MagniteEngineering/fledge.polyfill/wiki/Technical-Specification:-Auctions#renderadbidbid
Checklist
Have you considered all of the following?
Please confirm by checking off each item to ensure you've considered it:
Fixes: #52