-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move to idb-keyval
#72
Conversation
Codecov Report
@@ Coverage Diff @@
## main #72 +/- ##
==========================================
- Coverage 48.97% 47.20% -1.78%
==========================================
Files 11 10 -1
Lines 343 322 -21
Branches 133 131 -2
==========================================
- Hits 168 152 -16
+ Misses 99 94 -5
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but tests are failing. Let's get it to pass before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☕
Description
There was an issue, race condition, with
idb
where you had to create the dB first before you could add entries into it, but we can't always guarantee that the dB will exist first. The author ofidb
has a smaller, paired-down version of the library calledidb-keyval
.Screenshots (optional)
N/A
Additional context (optional)
https://github.com/jakearchibald/idb-keyval
Checklist
Have you considered all of the following?
Please confirm by checking off each item to ensure you've considered it:
Fixes: