Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move to idb-keyval #72

Merged
merged 5 commits into from
May 13, 2021
Merged

feat: move to idb-keyval #72

merged 5 commits into from
May 13, 2021

Conversation

iamnewton
Copy link
Contributor

Description

There was an issue, race condition, with idb where you had to create the dB first before you could add entries into it, but we can't always guarantee that the dB will exist first. The author of idb has a smaller, paired-down version of the library called idb-keyval.

Screenshots (optional)

N/A

Additional context (optional)

https://github.com/jakearchibald/idb-keyval

Checklist
Have you considered all of the following?

Please confirm by checking off each item to ensure you've considered it:

  • Did you create or update tests?
  • Did you create or update any documentation?

Fixes:

@iamnewton iamnewton requested a review from brodrigu May 13, 2021 18:04
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021

Codecov Report

Merging #72 (8ff8fde) into main (bd7b6eb) will decrease coverage by 1.77%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   48.97%   47.20%   -1.78%     
==========================================
  Files          11       10       -1     
  Lines         343      322      -21     
  Branches      133      131       -2     
==========================================
- Hits          168      152      -16     
+ Misses         99       94       -5     
  Partials       76       76              
Flag Coverage Δ
unittests 47.20% <70.00%> (-1.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/mocks/interest-groups.mock.js 100.00% <ø> (ø)
src/frame/auction/utils.js 20.21% <33.33%> (ø)
src/frame/interest-groups/index.js 90.90% <83.33%> (+0.90%) ⬆️
src/frame/auction/index.js 30.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd7b6eb...8ff8fde. Read the comment docs.

brodrigu
brodrigu previously approved these changes May 13, 2021
Copy link
Member

@brodrigu brodrigu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but tests are failing. Let's get it to pass before merging.

@iamnewton iamnewton enabled auto-merge (squash) May 13, 2021 19:10
@iamnewton iamnewton requested a review from brodrigu May 13, 2021 19:14
Copy link
Member

@brodrigu brodrigu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamnewton iamnewton merged commit 30cbf84 into main May 13, 2021
@iamnewton iamnewton deleted the change-to-idb-keyval branch May 13, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants