Move the Mailu Docker network to a fixed subnet. #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make network configuration and host based authentication more robust, across different deployment platforms. The options `RELAYNETS` and`POD_ADDRESS_RANGE` are kept for compatibility. However, their usage have become optional.
HorayNarea
previously approved these changes
Dec 6, 2018
|
Sorry, tests were failing. This is fixed now and ready for a new review ;) @HorayNarea |
HorayNarea
approved these changes
Dec 7, 2018
|
This whole singe review thing does not really work 😝 Merging manually. |
|
We need to point out that SUBNET variables need to be set to get imap authentification working.... |
2 tasks
bors bot
added a commit
that referenced
this pull request
Jun 26, 2021
1649: Update docs/reverse.rst with Traefik v2+ info r=mergify[bot] a=patryk-tech ## What type of PR? Documentation ## What does this PR do? Adds information about using Traefik v2+ as a reverse proxy. ### Related issue(s) Closes #1503 ## Prerequistes Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [x] In case of feature or enhancement: documentation updated accordingly - [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/guide.html#changelog) entry file. 1673: Remove rspamd unused env var from start script r=mergify[bot] a=cbachert ## What type of PR? Cleanup ## What does this PR do? Remove unused environment variable FRONT_ADDRESS in rspamd. FRONT_ADDRESS references were removed with commit 8172f3e in PR #727 like mentioned in chat https://matrix.to/#/!MINuyJjJSrfowljYCK:tedomum.net/$160401946364NGNmI:imninja.net?via=huisman.xyz&via=matrix.org&via=imninja.net ``` Mailu$ grep -r "FRONT_ADDRESS" core/rspamd/ core/rspamd/start.py:os.environ["FRONT_ADDRESS"] = system.get_host_address_from_environment("FRONT", "front") ``` ### Related issue(s) N/A ## Prerequistes - [x] Documentation updated accordingly: No documentation to update - [x] Add to changelog: Minor change 1718: Warn people off of the documentation's K8s recipe. r=mergify[bot] a=c4lliope Based on a discussion on Matrix (2020.12.19), the helm charts are the way to go. 1793: Fix Typo in Dutch Translation r=mergify[bot] a=DjVinnii ## What type of PR? Enhancement ## What does this PR do? There were 2 typos in the Dutch translation file. These typos are being fixed with this PR. ### Related issue(s) - None Co-authored-by: Patryk Tech <[email protected]> Co-authored-by: cbachert <[email protected]> Co-authored-by: Grace <[email protected]> Co-authored-by: Vincent Kling <[email protected]>
bors bot
added a commit
that referenced
this pull request
Jun 26, 2021
1649: Update docs/reverse.rst with Traefik v2+ info r=mergify[bot] a=patryk-tech ## What type of PR? Documentation ## What does this PR do? Adds information about using Traefik v2+ as a reverse proxy. ### Related issue(s) Closes #1503 ## Prerequistes Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [x] In case of feature or enhancement: documentation updated accordingly - [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/guide.html#changelog) entry file. 1673: Remove rspamd unused env var from start script r=mergify[bot] a=cbachert ## What type of PR? Cleanup ## What does this PR do? Remove unused environment variable FRONT_ADDRESS in rspamd. FRONT_ADDRESS references were removed with commit 8172f3e in PR #727 like mentioned in chat https://matrix.to/#/!MINuyJjJSrfowljYCK:tedomum.net/$160401946364NGNmI:imninja.net?via=huisman.xyz&via=matrix.org&via=imninja.net ``` Mailu$ grep -r "FRONT_ADDRESS" core/rspamd/ core/rspamd/start.py:os.environ["FRONT_ADDRESS"] = system.get_host_address_from_environment("FRONT", "front") ``` ### Related issue(s) N/A ## Prerequistes - [x] Documentation updated accordingly: No documentation to update - [x] Add to changelog: Minor change Co-authored-by: Patryk Tech <[email protected]> Co-authored-by: cbachert <[email protected]>
bors bot
added a commit
that referenced
this pull request
Jun 26, 2021
1649: Update docs/reverse.rst with Traefik v2+ info r=mergify[bot] a=patryk-tech ## What type of PR? Documentation ## What does this PR do? Adds information about using Traefik v2+ as a reverse proxy. ### Related issue(s) Closes #1503 ## Prerequistes Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [x] In case of feature or enhancement: documentation updated accordingly - [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/guide.html#changelog) entry file. 1673: Remove rspamd unused env var from start script r=mergify[bot] a=cbachert ## What type of PR? Cleanup ## What does this PR do? Remove unused environment variable FRONT_ADDRESS in rspamd. FRONT_ADDRESS references were removed with commit 8172f3e in PR #727 like mentioned in chat https://matrix.to/#/!MINuyJjJSrfowljYCK:tedomum.net/$160401946364NGNmI:imninja.net?via=huisman.xyz&via=matrix.org&via=imninja.net ``` Mailu$ grep -r "FRONT_ADDRESS" core/rspamd/ core/rspamd/start.py:os.environ["FRONT_ADDRESS"] = system.get_host_address_from_environment("FRONT", "front") ``` ### Related issue(s) N/A ## Prerequistes - [x] Documentation updated accordingly: No documentation to update - [x] Add to changelog: Minor change Co-authored-by: Patryk Tech <[email protected]> Co-authored-by: cbachert <[email protected]>
bors bot
added a commit
that referenced
this pull request
Jun 26, 2021
1649: Update docs/reverse.rst with Traefik v2+ info r=mergify[bot] a=patryk-tech ## What type of PR? Documentation ## What does this PR do? Adds information about using Traefik v2+ as a reverse proxy. ### Related issue(s) Closes #1503 ## Prerequistes Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [x] In case of feature or enhancement: documentation updated accordingly - [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/guide.html#changelog) entry file. 1673: Remove rspamd unused env var from start script r=mergify[bot] a=cbachert ## What type of PR? Cleanup ## What does this PR do? Remove unused environment variable FRONT_ADDRESS in rspamd. FRONT_ADDRESS references were removed with commit 8172f3e in PR #727 like mentioned in chat https://matrix.to/#/!MINuyJjJSrfowljYCK:tedomum.net/$160401946364NGNmI:imninja.net?via=huisman.xyz&via=matrix.org&via=imninja.net ``` Mailu$ grep -r "FRONT_ADDRESS" core/rspamd/ core/rspamd/start.py:os.environ["FRONT_ADDRESS"] = system.get_host_address_from_environment("FRONT", "front") ``` ### Related issue(s) N/A ## Prerequistes - [x] Documentation updated accordingly: No documentation to update - [x] Add to changelog: Minor change Co-authored-by: Patryk Tech <[email protected]> Co-authored-by: cbachert <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make network configuration and host based authentication
more robust, across different deployment platforms.
The options
RELAYNETSandPOD_ADDRESS_RANGEare kept for compatibility.However, their usage have become optional.
This is a re-submission of PR #721