info() function misbehaves when multiple plugins use ExamplePluginUpdater

[bonny]

I think there is a bug in the the class ExamplePluginUpdater and usage of the plugins_api filter.

The info() function
https://github.com/Make-Lemonade/lemonsqueezy-wp-updater-example/blob/main/includes/class-plugin-updater.php#L125-L146
returns false if the $action is of the wrong type, or if the plugin slug is not the wanted one, or if the remote request fails. I believe it should return the passed $result instead, because the plugins_api filter can be used multiple times, for example using the ExamplePluginUpdater multiple times for multiple plugins (that was my case).

Example: I have two plugins using the ExamplePluginUpdater class: "Plugin A" and "Plugin B".
In the WP plugin list page I click "View version 1.2.3 details" for Plugin A to view details about that plugin. Then the filter in ExamplePluginUpdater fetches info for that plugin and correctly returns an object (non-false value). However since the filter is also used for Plugin B it's called again and since it's not the correct plugin slug this time, it returns false and the result from Plugin A is discarded and the result for the user is "Plugin not found.".

I solved this by using return $result; instead of return false; in the info function and it works for me after that change.

[bdkoder]

Hi @bonny,
Please use namespace to solve the problem.
Thanks

[Brugman]

If you renamed ExamplePluginUpdater to be PluginAUpdater in Plugin A and PluginBUpdater in Plugin B, would this bug be avoided? (without namespaces)

Because that's what I think the name ExamplePluginUpdater is hinting at we should do.

[bonny]

@bdkoder @Brugman thanks for your feedback. I don't believe namespaces or different function names solves this. It's all about the return value.

It's the same kind of issue that for example was reported to this other plugin:
rudrastyh/misha-update-checker#1