-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the use of Ghostscript gs
command
#68
base: master
Are you sure you want to change the base?
Conversation
…script_jll and display warning.
Just commenting on one small part of this: I believe |
Yes, just stumble across it yesterday when trying to dig in my low-resolution latex issue. I also discovered const Ref which will be much better for the variable checking the availability of I'm still quite new to Julia. |
Thanks for the PR, will look into this and the rendering issue in more detail tomorrow. Are you still intending to make another commit, or should I review it as is? |
Sorry, working on another stuff, but I will commit to improve asap. Thanks. |
@asinghvi17 So here we are. I added a flake to work with Nix. Also made a proper dir for example files from the Tested successfully on my machine. I must mention that I still have the "pixelated" rendering issue, which is unrelated with the Ghostscript dynamically linked executables issue 67. |
This PR is linked to the following issue: Issue 67
I just moved all code that was building a
gs
command into a dedicated function that checks if thegs
command is available in the shell, else defaults to useGhostscript_jll
.This allows to fix the issue on Nixos.