Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form buttons are missing in Automate Explorer #1497

Closed
h-kataria opened this issue Jun 6, 2017 · 2 comments
Closed

Form buttons are missing in Automate Explorer #1497

h-kataria opened this issue Jun 6, 2017 · 2 comments
Assignees

Comments

@h-kataria
Copy link
Contributor

@martinpovolny can you please take a look, i have tried several different forms in Automate explorer, i don't see form buttons on any of them. Automate explorer is little bit different from other explorer screens as that does not use GTL views and paging controls so maybe the code that loads form buttons partials has to be handled differently in this case.
cc @karelhala

@h-kataria
Copy link
Contributor Author

h-kataria commented Jun 6, 2017

@skateman i think this is a JS issue, after some debugging i found out that form buttons are present in DOM but are not visible due to incorrect height calculation of main-content div. When i tired to modify height by hand in firebug console i was able to see the form buttons on screen, see before/after screenshots below

looks like height calculation needs to be adjusted here: https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/assets/javascripts/miq_application.js#L1542

before DOM changes
before

after DOM changes
after

@skateman
Copy link
Member

skateman commented Jun 7, 2017

This was introduced by @martinpovolny in #1467 when he pulled out the #form_buttons_div from the #paging_div, I'm finalizing the fix just now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants