Error in adv_search_build on a number of screens

[lgalis]

Errors occur on a number of screens after #776

Example 1: trace when selecting the Policy button for a cloud instance

[----] F, [2017-06-14T11:39:23.174670 #13627:5176b8c] FATAL -- : Error caught: [NoMethodError] undefined method []' for nil:NilClass /home/lgalis/dev/manageiq-ui-classic/app/controllers/application_controller/filter.rb:973:in adv_search_build'
/home/lgalis/dev/manageiq-ui-classic/app/controllers/application_controller.rb:1451:in get_view' /home/lgalis/dev/manageiq-ui-classic/app/controllers/application_controller.rb:370:in report_data'
/home/lgalis/.rvm/gems/ruby-2.3.1/gems/actionpack-5.0.3/lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action'

[lgalis]

@miq-bot assign @lgalis

[lgalis]

@hstastna -
I see here
https://github.com/ManageIQ/manageiq-ui-classic/pull/776/files#diff-08a3013ef490c3273c6b0ffc7c84a0eaR950 that we are now copying the session[:edit] into @edit
instead of session[:adv_search][model.to_s] ( the of branch still tests for this).
What is the reason for this change?

[hstastna]

@lgalis the reason of the change is simple: it was needed to make it work. As I remember, I needed session[:edit] there, not just the model. Some data was missing there from session[:edit]. But as I see now, I have to check it again and figure out what's going on here. I am not sure that I understand the error. Could you provide more info that I can reproduce the errors? Thanks, Laura :)

[hstastna]

@lgalis update: I get the error even if I edit my change from https://github.com/ManageIQ/manageiq-ui-classic/pull/776/files#diff-08a3013ef490c3273c6b0ffc7c84a0eaR950 to what it was before. The error still exists, but different type of error. So I am not sure that this change from my PR causes the errors. I think there is a problem somewhere else (or a combination of more bugs)...

[lgalis]

@hstastna , there are more bugs, but this issue needs to be fixed - at the minimum- the if condition needs to be updated as well if what is copied into @edit has changed.

[lgalis]

@hstastna - Karel has fixed this in #1549

[hstastna]

@lgalis Oh, nice! But I don't see that he would change the line from my PR #776 you have mentioned before to what it was before. Should I make a change in filter.rb? I mean, to change @edit = copy_hash(session[:edit]) to
@edit = copy_hash(session[:adv_search][model.to_s])
If yes, I can make a PR for the change. But I am not sure if it helps to something.

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

[JPrause]

@lgalis @hstastna is this still a valid issue? If yes, lease remove the stale label. If not can you close.
If there's no update by next week, I'll be closing this issue.

[JPrause]

Closing issue. If you feel the issue needs to remain open, please either reopen or let me know and it will be reopened.
@miq-bot close_issue