Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in IDL #90

Closed
zcorpan opened this issue Jun 29, 2020 · 2 comments
Closed

Errors in IDL #90

zcorpan opened this issue Jun 29, 2020 · 2 comments
Assignees
Labels

Comments

@zcorpan
Copy link

zcorpan commented Jun 29, 2020

[NamedConstructor=Map(unsigned long width, unsigned long height, double lat, double lon, unsigned short zoom, optional string projection, boolean controls)]
interface HTMLMapElement : HTMLElement {
   readonly attribute HTMLCollection layers;
   readonly attribute HTMLCollection areas;
   readonly attribute unsigned short zoom;
   readonly attribute double lat;
   readonly attribute double lon;
   readonly attribute string projection;
   attribute boolean controls;
   attribute unsigned long width;
   attribute unsigned long height;
   void zoomTo(double latitude, double longitude, optional unsigned short zoom);
};
  • string should be DOMString
  • [Exposed=Window] is missing
  • [HTMLConstructor] constructor(); is missing
  • IDL attributes that reflect content attributes should have [CEReactions]
  • IDL attributes that return HTMLCollection should have [SameObject]
  • NamedConstructor was changed to [LegacyFactoryFunction].

see https://html.spec.whatwg.org/multipage/image-maps.html#the-map-element

@prushforth prushforth self-assigned this Jul 3, 2020
@prushforth prushforth transferred this issue from Maps4HTML/HTML-Map-Element Jul 22, 2020
@Malvoz
Copy link
Member

Malvoz commented Oct 30, 2020

It should be noted that while some errors exist, most of the ones described above were fixed in bcfeb6a.

@Malvoz Malvoz added the bug label Nov 1, 2020
@Malvoz
Copy link
Member

Malvoz commented Sep 8, 2021

AFAIK these are all fixed:

  • string should be DOMString
  • [Exposed=Window] is missing
  • [HTMLConstructor] constructor(); is missing
  • IDL attributes that reflect content attributes should have [CEReactions]
  • IDL attributes that return HTMLCollection should have [SameObject]
  • NamedConstructor was changed to [LegacyFactoryFunction].

Closing in favor of #212 for the remaining issues.

@Malvoz Malvoz closed this as completed Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants