Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug tiles shouldn't use non-standard HTML attributes #191

Open
Malvoz opened this issue Oct 20, 2020 · 4 comments
Open

Debug tiles shouldn't use non-standard HTML attributes #191

Malvoz opened this issue Oct 20, 2020 · 4 comments

Comments

@Malvoz
Copy link
Member

Malvoz commented Oct 20, 2020

col, row and zoom are non-standard attributes on <div> elements. Authors may be flagged for using invalid HTML when validating their web pages that has the component embedded. Use data- attributes instead?

@Malvoz
Copy link
Member Author

Malvoz commented Oct 20, 2020

May also be motivated by #176.

@prushforth
Copy link
Member

Authors may be flagged for using invalid HTML when validating their web pages that has the component embedded.

Doubtful of this; the <div>s in question are found in the shadow root, and as such are dynamic, and created by code at run time. I don't think a validator looks inside the shadow root for a <video> controls, for instance.

I'm not saying it would hurt to use data- attributes, just that I don't it's a big deal / internal concern is all.

@Malvoz
Copy link
Member Author

Malvoz commented Oct 20, 2020

I think this is a similar consideration to #174. If we create customattr today and an attribute with the same name is added to the web platform tomorrow they would conflict (even if in Shadow DOM). It's probably quite unlikely that these particular attributes would ever be added as global attributes (applies to <div>) to the HTML spec though.

@Malvoz
Copy link
Member Author

Malvoz commented Feb 15, 2021

There's a related TAG issue here: w3ctag/webcomponents-design-guidelines#2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants