Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review consistency of the <layer- checked> (and <extent checked>) attribute with <input checked> #716

Closed
prushforth opened this issue Jan 15, 2023 · 1 comment

Comments

@prushforth
Copy link
Member

prushforth commented Jan 15, 2023

In reviewing how our elements' design relates to the Web Platform Design Principles, we're told to ensure consistency of attribute use with existing attributes of the same name.

We should review checked to ensure some consistency with the API of the <input checked> attribute. That said, our use of checked is a bit different from that of <input>, but it does have similar UI implications.

The checked attribute seems to be one of the few counterpatterns that is listed that should not be kept in sync with the IDL attribute (property).

@yhy0217
Copy link
Contributor

yhy0217 commented Nov 8, 2023

Resolved in #887

The checked attribute seems to be one of the few counterpatterns that is listed that should not be kept in sync with the IDL attribute (property).

The current implementation follows the pattern, the checked attribute is kept sync with the IDL attribute.

@yhy0217 yhy0217 closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants