From b2a92fd113eccada907eff1ac77d805078d2e0f2 Mon Sep 17 00:00:00 2001 From: Mark Waite Date: Thu, 21 Dec 2023 04:14:38 -0700 Subject: [PATCH] Omit spotbugs CT_CONSTRUCTOR_THROWS visitor From https://github.com/jenkinsci/plugin-pom/pull/869#issuecomment-1860918407 > Discussion in spotbugs/spotbugs#2695 > https://wiki.sei.cmu.edu/confluence/display/java/OBJ11-J.+Be+wary+of+letting+constructors+throw+exceptions > seems to relate to libraries used with SecurityManager which is dead > and certainly does not apply to Jenkins; we do not expect untrusted code > to be running inside the controller JVM, and it does not seem plausible > that finalizer abuse would happen by accident. --- pom.xml | 3 +++ src/spotbugs/excludesFilter.xml | 9 --------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/pom.xml b/pom.xml index e075c3530..e6afda6a2 100644 --- a/pom.xml +++ b/pom.xml @@ -50,6 +50,9 @@ 4.8.2.0 Max Low + + + ConstructorThrow,FindReturnRef false diff --git a/src/spotbugs/excludesFilter.xml b/src/spotbugs/excludesFilter.xml index 67a66e170..486e7943c 100644 --- a/src/spotbugs/excludesFilter.xml +++ b/src/spotbugs/excludesFilter.xml @@ -4,15 +4,6 @@ Exclusions in this section have been triaged and determined to be false positives. --> - - - - - - - - -