Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] pin postprocessing destroys SPI CS pins #23777

Closed
FGSikasa opened this issue Feb 21, 2022 · 5 comments
Closed

[BUG] pin postprocessing destroys SPI CS pins #23777

FGSikasa opened this issue Feb 21, 2022 · 5 comments

Comments

@FGSikasa
Copy link

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

setting in configuration.h
#define X_DRIVER_TYPE TMC26X
#define Y_DRIVER_TYPE TMC26X
#define Z_DRIVER_TYPE TMC26X

With the above setting:
The STEP_PINs, DIR_PINs and ENABLE_PINs are set properly but the postprocessing in pin_postprocess.h sets the CS_PINs to -1.

//
// Destroy unused CS pins
//
#if !AXIS_HAS_SPI(X)
#undef X_CS_PIN
#endif
#if !AXIS_HAS_SPI(Y)
#undef Y_CS_PIN
#endif
#if !AXIS_HAS_SPI(Z)
#undef Z_CS_PIN
#endif

Is it possible to disable the E_Stepper, the Heater and the temperature sensor ?

I would like to test only the X, Y and Z Steppers.

Bug Timeline

No response

Expected behavior

No response

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

Marlin version 2.0.9.3

Printer model

custom

Electronics

No response

Add-ons

No response

Bed Leveling

No response

Your Slicer

No response

Host Software

No response

Additional information & file uploads

No response

@ellensp
Copy link
Contributor

ellensp commented Feb 21, 2022

macro AXIS_HAS_SPI( axis ) fails to identify that TMC26X uses SPI

Fixing the macro is easy, but shows more issues...

@ellensp
Copy link
Contributor

ellensp commented Feb 21, 2022

@FGSikasa please try this PR

@ellensp
Copy link
Contributor

ellensp commented Feb 21, 2022

"Is it possible to disable the E_Stepper, the Heater and the temperature sensor ?" is a support question. not a bug report or issue so I direct you to the following resources for answers.

@thisiskeithb
Copy link
Member

#23778 has been merged.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants