Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Make negative coordinates possible on (full) Graphic LCDs #2954

Closed
AnHardt opened this issue Jan 30, 2016 · 8 comments
Closed
Labels
T: Feature Request Features requested by users.

Comments

@AnHardt
Copy link
Contributor

AnHardt commented Jan 30, 2016

Make negative coordinates possible on (full) Graphic LCDs.

@thinkyhead
Copy link
Member

Is this still not done? It should be a pretty quick fix, yes?

@thinkyhead thinkyhead added the T: Feature Request Features requested by users. label Mar 16, 2016
@AnHardt
Copy link
Contributor Author

AnHardt commented Mar 16, 2016

No space. For negative numbers we have to drop a digit.
Did not make sense to me before #2989 (or one of the predecessors) was merged (changing the same lines of code).

@Roxy-3D
Copy link
Member

Roxy-3D commented Mar 16, 2016

Maybe the number could be done in inverse video to indicate it has flipped to minus? That is kind of a kludged solution, but if there is no space for a minus sign... and the feature is needed, some way needs to be found to indicate the status....

@AnHardt
Copy link
Contributor Author

AnHardt commented Mar 16, 2016

#2675 (comment)
is already a reasonable plan i think. For that small numbers between -100 to -999 you don't need the last digit - if displaying the x/y-coordinates makes sense at all.

@Roxy-3D
Copy link
Member

Roxy-3D commented Mar 16, 2016

The LCD Panels are slow enough as it is... But with a proportional font, digits (and decimal point) would pack tighter together. But "Yes!" When you are in the range of -100 to -999 you can afford to lose a digit.

@thinkyhead
Copy link
Member

Yeah, I was thinking also, just drop a digit. But for a very big delta, -100 might just be far from center. Hmm....

@AnHardt
Copy link
Contributor Author

AnHardt commented Mar 18, 2016

display_error = abs(position - displayed_postition)
position = -100.1
displayed_position "100.1" > display_error = 200.2
displayed_position "-100." > display_error = 0.1

position = -998.9
displayed_position "998.9" > display_error = 1,997.8
displayed_position "-999." > display_error = 0.1

Even in a bad implementation the display_error is never larger than 1.
The sign is much more important, than to know about the digits behind the dot.

If you want to know a more exact reading you could go to the move_menu, where we have infinite room to display digits.

@AnHardt AnHardt closed this as completed May 2, 2016
@github-actions
Copy link

github-actions bot commented Apr 9, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: Feature Request Features requested by users.
Projects
None yet
Development

No branches or pull requests

3 participants