Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M145 format in initial output is wrong #3046

Closed
nebbian opened this issue Feb 27, 2016 · 4 comments
Closed

M145 format in initial output is wrong #3046

nebbian opened this issue Feb 27, 2016 · 4 comments

Comments

@nebbian
Copy link

nebbian commented Feb 27, 2016

The M145 command (Set the heatup state for Ultimaker panel) when shown in the initial output of the serial console is wrong. It currently shows:

echo:  M145 M0 H180 B65 F255
echo:  M145 M1 H240 B105 F255

This should be:

echo:  M145 S0 H180 B65 F255
echo:  M145 S1 H240 B105 F255

This is going by the code that handles the M145 command, which states:

  /**
   * M145: Set the heatup state for a material in the LCD menu
   *   S<material> (0=PLA, 1=ABS)
   *   H<hotend temp>
   *   B<bed temp>
   *   F<fan speed>
   */
@thinkyhead
Copy link
Member

Thanks! I've created patches, so this will be fixed up in the next release candidate.

@CONSULitAS
Copy link
Contributor

btw:
Reprap Wiki (http://reprap.org/wiki/Gcode#M144:_Stand_By_Your_Bed) doesn't know M145.

Hmmm. 😞

@thinkyhead
Copy link
Member

M145 is a Marlin extension that I added to accompany some items written to EEPROM. So it's not yet finalized or formalized. We might replace the parameter letters, since it's not very GCode-like to use H and B, while F is usually reserved for feedrate. There's nothing inherently bad about using unique letter parameters in a GCode, but some sticklers don't like it, and some firmwares might later resist adopting them.

@jbrazio jbrazio modified the milestone: 1.1.0 Jul 16, 2016
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants