Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PID autotune FAILED #3990

Closed
focamonca opened this issue Jun 9, 2016 · 16 comments
Closed

PID autotune FAILED #3990

focamonca opened this issue Jun 9, 2016 · 16 comments

Comments

@focamonca
Copy link

focamonca commented Jun 9, 2016

When I Try to Give the PID AUTOTUNE for the bed this is the result:

SENT: M303 E-1 S60 C10
RECEIVED: PID Autotune failed! Bad extruder number
RECEIVED: ok

@focamonca
Copy link
Author

focamonca commented Jun 9, 2016

  #define  DEFAULT_bedKp 234
  #define  DEFAULT_bedKi 43.28
  #define  DEFAULT_bedKd 316.28
  //120V 250W silicone heater into 4mm borosilicate (MendelMax 1.5+)
  //from pidautotune
  //#define  DEFAULT_bedKp 97.1
  //#define  DEFAULT_bedKi 1.41
  //#define  DEFAULT_bedKd 1675.16
  // FIND YOUR OWN: "M303 E-1 C8 S90" to run autotune on the bed at 90 degreesC for 8 cycles.
#endif // PIDTEMPBED

This is as is written on Config.h

@Blue-Marlin
Copy link
Contributor

    if (false
      #if ENABLED(PIDTEMP)
         || hotend >= HOTENDS
      #else
         || hotend >= 0
      #endif
      #if DISABLED(PIDTEMPBED)
         || hotend < 0
      #endif
    ) {
      SERIAL_ECHOLN(MSG_PID_BAD_EXTRUDER_NUM);
      return;
    }

Is PIDTEMPBED active?

@Blue-Marlin
Copy link
Contributor

Blue-Marlin commented Jun 9, 2016

Oops.

    if (false
      #if ENABLED(PIDTEMP)
         || hotend >= HOTENDS
      #else
         || hotend >= 0
      #endif
      #if DISABLED(PIDTEMPBED)
         || hotend < 0
      #endif
+     || hotend < -1
    ) {
      SERIAL_ECHOLN(MSG_PID_BAD_EXTRUDER_NUM);
      return;
    }

@thinkyhead
Copy link
Member

thinkyhead commented Jun 9, 2016

Ups.

Oops! 😵 Props!

Yes, I guess that would be good to add. It can replace the false clause at the top.

@focamonca
Copy link
Author

I did't understood how to solve the problem LOL

@Blue-Marlin
Copy link
Contributor

If you have PIDTEMPBED not activated you will get the error. No PID for the bed -> No tuning the PID for the bed.

@Anton73rus
Copy link

Anton73rus commented Sep 22, 2016

Please correct source:

if (hotend >=
        #if ENABLED(PIDTEMP)
          HOTENDS
        #else
          0
        #endif
      || hotend <
        #if DISABLED(PIDTEMPBED) //(**It was Enabled**) 
          -1
        #else
          0
        #endif
    ) {
      SERIAL_ECHOLN(MSG_PID_BAD_EXTRUDER_NUM);
      return;
    }

@Blue-Marlin
Copy link
Contributor

Please rethink,try and close the issue.
-1 is the number of the bed!

@Anton73rus
Copy link

if I'm wrong ? then why after the code has changed - I have gone error : "PID Autotune failed Bad extruder number!", and began autotune? = ) I apologize if the text with errors - I translate through Google translator :D

@Blue-Marlin
Copy link
Contributor

Blue-Marlin commented Sep 23, 2016

Likely because you have not activated 'PIDTEMPBED'.
The tuning will work even without that.

@thinkyhead
Copy link
Member

thinkyhead commented Sep 24, 2016

@Anton73rus

The code is correct.

Do you have the option set…?

#define PIDTEMPBED

@micahobaca
Copy link

I finally got it to work, you have to heat your bed withing 10 degrees of your target temperature then run the pid autotune, then it will work, as long as you have the pid autotune enabled in your marlin code and that other option below it commented out you are good to go, try that and let me know if it worked for you, if you haven't already figured it out.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

3 similar comments
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants